Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Natspec input verifier and custom errors #226

Merged
merged 4 commits into from
Dec 31, 2024
Merged

chore: Natspec input verifier and custom errors #226

merged 4 commits into from
Dec 31, 2024

Conversation

PacificYield
Copy link
Contributor

@PacificYield PacificYield commented Dec 31, 2024 •
edited
Loading

This PR:

  • adds NatSpec to function headers and other best practices.
  • updates the codegen
  • replaces verbose require statements with custom errors

@PacificYield PacificYield force-pushed the natspec-input-verifier branch 2 times, most recently from b62a158 to db5c2ac Compare December 31, 2024 10:13
@PacificYield PacificYield self-assigned this Dec 31, 2024
@PacificYield PacificYield force-pushed the natspec-input-verifier branch from db5c2ac to 9c3f173 Compare December 31, 2024 11:08
@PacificYield PacificYield changed the title chore: Natspec input verifier and custom errors (WIP) chore: Natspec input verifier and custom errors Dec 31, 2024
@PacificYield PacificYield requested a review from jatZama December 31, 2024 11:27
@PacificYield PacificYield marked this pull request as ready for review December 31, 2024 11:27
@jatZama jatZama self-requested a review December 31, 2024 13:37
jatZama
jatZama requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@jatZama jatZama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add custom error test instead of just testing a revert.

@jatZama jatZama self-requested a review December 31, 2024 14:09
jatZama
jatZama requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@jatZama jatZama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix test before merging

@PacificYield PacificYield force-pushed the natspec-input-verifier branch from 11b83a8 to db4f9e4 Compare December 31, 2024 14:15
@PacificYield PacificYield force-pushed the natspec-input-verifier branch from db4f9e4 to 01265ff Compare December 31, 2024 14:16
@PacificYield PacificYield requested a review from jatZama December 31, 2024 14:22
@PacificYield PacificYield merged commit 25267db into main Dec 31, 2024
3 checks passed
@PacificYield PacificYield deleted the natspec-input-verifier branch December 31, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatZama jatZama jatZama approved these changes

Assignees

@PacificYield PacificYield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PacificYield @jatZama