Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 64bits support #284

Merged
merged 11 commits into from
Feb 14, 2024
Merged

feat: add 64bits support #284

merged 11 commits into from
Feb 14, 2024

Conversation

immortal-tofu
Copy link
Collaborator

@immortal-tofu immortal-tofu commented Feb 9, 2024

@cla-bot cla-bot bot added the cla-signed label Feb 9, 2024
@immortal-tofu immortal-tofu marked this pull request as ready for review February 9, 2024 15:18
@immortal-tofu
Copy link
Collaborator Author

Tests won't work until we have a proper dev image cc @leventdem

@jatZama
Copy link
Member

jatZama commented Feb 9, 2024

Tests won't work until we have a proper dev image cc @leventdem

is this what is causing the nonce errors in the tests?

Copy link
Member

@jatZama jatZama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct not_euint32 in overload.ts

@immortal-tofu
Copy link
Collaborator Author

immortal-tofu commented Feb 9, 2024

Tests won't work until we have a proper dev image cc @leventdem

is this what is causing the nonce errors in the tests?

Yes, basically the first test to fail make the next tests failing for a nonce reason. Two things change regarding running tests:

  • We need the new stack with 64bits support and tfhe-rs 0.5.1
  • We need a computer capable to run multiplication over two euint64 in less than 7seconds: this is not possible on my M1 or on the default CI. That's why I switched to large_ubuntu_16 in GitHub Actions.

Copy link
Contributor

@david-zk david-zk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@immortal-tofu immortal-tofu merged commit bddef09 into main Feb 14, 2024
4 checks passed
@immortal-tofu immortal-tofu deleted the feature/64bits branch February 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants