-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 64bits support #284
Conversation
immortal-tofu
commented
Feb 9, 2024
•
edited
Loading
edited
- Tests are running on the CI launched manually with latest version of KMS/fhevm-go https://github.com/zama-ai/zbc-ethermint/actions/runs/7844274084/job/21408137996
- Mocks has been updated to support 64bits
- Contracts has been moved to euint64 (ERC20/Governor/Comp/Identity/...)
- fhevmjs has a prerelease which supports 64bits https://github.com/zama-ai/fhevmjs/releases
Tests won't work until we have a proper dev image cc @leventdem |
is this what is causing the nonce errors in the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct not_euint32 in overload.ts
Yes, basically the first test to fail make the next tests failing for a nonce reason. Two things change regarding running tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
2617009
to
26f1d96
Compare
26f1d96
to
d7c3656
Compare