-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Add language switcher to the page header. #169
Conversation
I think we can't prevent it from going to pre-release as well (latest with the next merge/reset). It must be robust enough to detect that. How does it work for the pre-release warning badge that is there currently? It must detect this somehow, based on build environment data. |
OTOH, pre-release can also be translated. We just don't publish the translations (yet). |
Unless we don't reset it anymore? Note that Warning badge is powered by the I found a way to skip the injection of the language switcher in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice!!
@ralf401 @mgruner I think we should apply this only to the
main
branch, since we don't publish translations for thepre-release
. What do you think?