Skip to content

Commit

Permalink
rename path filtering job and step
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesclark-Zapata committed Apr 23, 2024
1 parent 980e4a8 commit 09c0c32
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/all-pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ on:
workflow_dispatch:
jobs:
# This job checks for the changed paths
changes:
find-changes:
name: Get changed packages
runs-on: ubuntu-latest
permissions:
pull-requests: read
outputs:
packages: ${{ steps.filter.outputs.changes }}
packages: ${{ steps.filter-paths.outputs.changes }}
steps:
- uses: dorny/paths-filter@v3
id: filter
id: filter-paths
with:
# We can codify the path dependencies between the packages here
filters: |
Expand All @@ -24,10 +24,10 @@ jobs:
- projects/orquestra-sdk/**
tests:
# call the reusable workflow for the packages that changed
needs: changes
needs: find-changes
strategy:
matrix:
package: ${{ fromJSON(needs.changes.outputs.packages) }}
package: ${{ fromJSON(needs.find-changes.outputs.packages) }}
uses: ./.github/workflows/package-coverage.yml
with:
target_path: ${{ matrix.package }}
Expand All @@ -37,10 +37,10 @@ jobs:
python_versions: '["3.11", "3.9"]'
style:
# call the reusable workflow for the packages that changed
needs: changes
needs: find-changes
strategy:
matrix:
package: ${{ fromJSON(needs.changes.outputs.packages) }}
package: ${{ fromJSON(needs.find-changes.outputs.packages) }}
uses: ./.github/workflows/package-style.yml
with:
target_path: ${{ matrix.package }}
Expand All @@ -55,7 +55,7 @@ jobs:
if: always()
name: Check all tests passed
needs:
- changes
- find-changes
- tests
- style
runs-on: ubuntu-latest
Expand Down

0 comments on commit 09c0c32

Please sign in to comment.