Skip to content

Commit

Permalink
remove SDK from base image
Browse files Browse the repository at this point in the history
  • Loading branch information
SebastianMorawiec committed Aug 22, 2024
1 parent b1e7275 commit a02a7c5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 20 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/publish-cuda-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@ name: Publish orquestra-sdk-base Docker Image with CUDA support
on:
workflow_dispatch:
inputs:
sdk_requirement:
type: string
description: |
Orquestra SDK requirement to build the image with.
Example of using a published version of the SDK:
orquestra-sdk[ray]==0.63.0
Example of using an unpublished version:
orquestra-sdk[ray] @ git+https://github.com/zapata-engineering/[email protected]#subdirectory=projects/orquestra-sdk
docker_tag:
type: string
description: |
Expand Down Expand Up @@ -81,6 +73,6 @@ jobs:
# as on the command line `--build-arg`, one to a line:
# docker_build_args: BUILD_ARG_ONE=value1\nBUILD_ARG_TWO=value2
# DUE TO JSON LIMITATIONS, NEWLINES MUST BE EXPLICITLY ADDED AS \n
docker_build_args: SDK_REQUIREMENT=${{ inputs.sdk_requirement }}
docker_build_args:
# leave blank for linux/amd64 (recommended)
target_platforms: ''
10 changes: 1 addition & 9 deletions .github/workflows/publish-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@ name: Publish orquestra-sdk-base Docker Image
on:
workflow_dispatch:
inputs:
sdk_requirement:
type: string
description: |
Orquestra SDK requirement to build the image with.
Example of using a published version of the SDK:
orquestra-sdk[ray]==0.63.0
Example of using an unpublished version:
orquestra-sdk[ray] @ git+https://github.com/zapata-engineering/[email protected]#subdirectory=projects/orquestra-sdk
docker_tag:
type: string
description: |
Expand Down Expand Up @@ -79,6 +71,6 @@ jobs:
# as on the command line `--build-arg`, one to a line:
# docker_build_args: BUILD_ARG_ONE=value1\nBUILD_ARG_TWO=value2
# DUE TO JSON LIMITATIONS, NEWLINES MUST BE EXPLICITLY ADDED AS \n
docker_build_args: SDK_REQUIREMENT=${{ inputs.sdk_requirement }}
docker_build_args:
# leave blank for linux/amd64 (recommended)
target_platforms: 'linux/amd64,linux/arm64'
3 changes: 1 addition & 2 deletions projects/orquestra-sdk/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# Base image for running Orquestra tasks.
# Published at hub.nexus.orquestra.io/zapatacomputing/orquestra-sdk-base
FROM python:3.11.6-slim-bullseye
ARG SDK_REQUIREMENT

# Set by BuildKit
ARG TARGETARCH
Expand Down Expand Up @@ -38,7 +37,7 @@ RUN <<EOF
set -ex
. "$VIRTUAL_ENV/bin/activate"
python -m pip install --no-cache-dir -U pip wheel
python -m pip install --no-cache-dir "${SDK_REQUIREMENT}"
python -m pip install --no-cache-dir ray[default]==2.30
EOF

# Prefer to use pip, python, and other binaries from the virtual env.
Expand Down

0 comments on commit a02a7c5

Please sign in to comment.