-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
int: Initial monorepo #392
Merged
jamesclark-Zapata
merged 18 commits into
main
from
int/jamesclark-zapata/orqsdk-1030/monorepo-init
May 1, 2024
Merged
int: Initial monorepo #392
jamesclark-Zapata
merged 18 commits into
main
from
int/jamesclark-zapata/orqsdk-1030/monorepo-init
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Code Coverage
|
jamesclark-Zapata
force-pushed
the
int/jamesclark-zapata/orqsdk-1030/monorepo-init
branch
from
April 20, 2024 01:08
6ba9c8d
to
3cfa181
Compare
jamesclark-Zapata
force-pushed
the
int/jamesclark-zapata/orqsdk-1030/monorepo-init
branch
from
April 22, 2024 04:48
76521ad
to
3e9ae17
Compare
alexjuda
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Added non-blocking suggestions
alexjuda
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Added non-blocking suggestions
jamesclark-Zapata
force-pushed
the
int/jamesclark-zapata/orqsdk-1030/monorepo-init
branch
from
April 23, 2024 03:08
3e3fe0a
to
4467194
Compare
Co-authored-by: Alexander Juda <[email protected]>
jamesclark-Zapata
force-pushed
the
int/jamesclark-zapata/orqsdk-1030/monorepo-init
branch
from
April 24, 2024 19:32
4467194
to
924de78
Compare
jamesclark-Zapata
deleted the
int/jamesclark-zapata/orqsdk-1030/monorepo-init
branch
May 1, 2024 16:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
In preparation for separate packages, we require a monorepo setup.
This PR's solution
Implements the ADR, excluding a rye workspace which can be added at any time later.
orquestra-sdk
is moved to theprojects/
directoryThis workflow has a single job that can be used as the required check. This only passes if all the style checks/tests that were actually run pass.
Note: the nightly workflow hasn't been tested yet because I renamed it and it won't show up in the UI until it's on
main
.Checklist
Check that this PR satisfies the following items:
<feat/fix/chore/imp[rovement]/int[ernal]/docs>[!]: