Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update runtime dependency on published shared library #416

Merged
merged 1 commit into from
May 28, 2024

Conversation

SebastianMorawiec
Copy link
Contributor

@SebastianMorawiec SebastianMorawiec commented May 28, 2024

The problem

I cannot publish runtime lib on PyPi as it depends on local version of SHARED which is disallowed on PyPI

This PR's solution

Fix dependency

Checklist

Check that this PR satisfies the following items:

  • Tests have been added for new features/changed behavior (if no new features have been added, check the box).
  • The changelog file has been updated with a user-readable description of the changes (if the change isn't visible to the user in any way, check the box).
  • The PR's title is prefixed with <feat/fix/chore/imp[rovement]/int[ernal]/docs>[!]:
  • The PR is linked to a JIRA ticket (if there's no suitable ticket, check the box).

@SebastianMorawiec SebastianMorawiec requested a review from a team May 28, 2024 12:47
Copy link

github-actions bot commented May 28, 2024

🚀 Code Coverage

-----------------------------------------------------------------------------------------------
src/orquestra/sdk/_client/_base/_api/_config.py                     144      7    95%   255-263, 265, 369-375
src/orquestra/sdk/_client/_base/_api/_task_run.py                   120      4    97%   66, 283, 303, 307
src/orquestra/sdk/_client/_base/_api/_wf_run.py                     286     20    93%   101, 130-131, 166, 256-260, 281-282, 389-390, 417, 611, 720-721, 739, 783, 794-795, 814
src/orquestra/sdk/_client/_base/_ast.py                             108      1    99%   222
src/orquestra/sdk/_client/_base/_config.py                          159      2    99%   410-411
src/orquestra/sdk/_client/_base/_driver/_ce_runtime.py              232      5    98%   64, 188, 193, 451, 733
src/orquestra/sdk/_client/_base/_driver/_client.py                  368      8    98%   213-214, 231-232, 240-241, 1144-1145
src/orquestra/sdk/_client/_base/_driver/_models.py                  222      1    99%   577
src/orquestra/sdk/_client/_base/_dsl.py                             415     16    96%   37, 301, 565-574, 1045, 1048-1049, 1057-1058, 1096-1098, 1123, 1138, 1154
src/orquestra/sdk/_client/_base/_factory.py                          26      1    96%   40
src/orquestra/sdk/_client/_base/_in_process_runtime.py              135      9    93%   104-107, 181-182, 272, 318, 394
src/orquestra/sdk/_client/_base/_services.py                         43      8    81%   19, 22, 25, 28, 101-102, 122-123
src/orquestra/sdk/_client/_base/_spaces/_api.py                      28      4    86%   31-32, 57-58
src/orquestra/sdk/_client/_base/_testing/_connections.py             38      6    84%   34, 43-56, 83-85
src/orquestra/sdk/_client/_base/_testing/_example_wfs.py            229     15    93%   55, 61, 93, 105, 112, 221-223, 248-251, 288, 327-330, 340, 395
src/orquestra/sdk/_client/_base/_traversal.py                       302      7    98%   349, 396, 440, 515, 527, 700, 720
src/orquestra/sdk/_client/_base/_viz.py                              62      5    92%   53-58, 63
src/orquestra/sdk/_client/_base/_workflow.py                        220     19    91%   179, 186-187, 351, 370, 372, 377-381, 497-501, 551-552, 570, 587, 600, 614
src/orquestra/sdk/_client/_base/cli/_arg_resolvers.py               189      1    99%   184
src/orquestra/sdk/_client/_base/cli/_config/_list.py                 25      5    80%   35-38, 52
src/orquestra/sdk/_client/_base/cli/_dumpers.py                      60      3    95%   140, 156-157
src/orquestra/sdk/_client/_base/cli/_entry.py                       154     33    79%   135-138, 146-149, 175-178, 217-220, 246-249, 329-332, 343-346, 363-366, 380-383, 413-416, 488-491
src/orquestra/sdk/_client/_base/cli/_login/_login.py                 59      2    97%   81-82
src/orquestra/sdk/_client/_base/cli/_repos.py                       242     12    95%   119-120, 152-153, 320-321, 327, 499-500, 700-701, 718
src/orquestra/sdk/_client/_base/cli/_task/_results.py                30      2    93%   52-53
src/orquestra/sdk/_client/_base/cli/_ui/_click_default_group.py      62      3    95%   150-152
src/orquestra/sdk/_client/_base/cli/_ui/_errors.py                  141     18    87%   72-78, 165, 185-187, 192-194, 199-200, 240-241, 244-245, 250-251
src/orquestra/sdk/_client/_base/cli/_ui/_presenters.py              190      3    98%   49-52, 137
src/orquestra/sdk/_client/_base/cli/_ui/_prompts.py                  89     45    49%   44, 54, 97, 110, 127-136, 145, 154, 181, 191-205, 229-260, 283-299
src/orquestra/sdk/_client/_base/cli/_workflow/_list.py               33      2    94%   71-72
src/orquestra/sdk/_client/_base/cli/_workflow/_logs.py               38      2    95%   105-106
src/orquestra/sdk/_client/_base/cli/_workflow/_submit.py             48      1    98%   143
src/orquestra/sdk/_client/_base/cli/_workflow/_view.py               22      2    91%   45-46
src/orquestra/sdk/_client/_base/loader.py                            64      2    97%   146-147
src/orquestra/sdk/examples/exportable_wf.py                          21      5    76%   20, 30, 41, 53, 58
src/orquestra/sdk/examples/workflow_defs.py                          21     11    48%   11-14, 19, 24-28, 33
-----------------------------------------------------------------------------------------------
TOTAL                                                              5155    290    94%

19 files skipped due to complete coverage.
-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
No lines with coverage information in this diff.
-------------

@SebastianMorawiec SebastianMorawiec enabled auto-merge (squash) May 28, 2024 12:54
@SebastianMorawiec SebastianMorawiec merged commit afa7c6c into main May 28, 2024
15 checks passed
@SebastianMorawiec SebastianMorawiec deleted the Morawiec/fix_runtime branch May 28, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants