Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat!: Remove deprecated project_dir argument #453

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

SebastianMorawiec
Copy link
Contributor

@SebastianMorawiec SebastianMorawiec commented Oct 9, 2024

The problem

project_dir was deprecated long time ago, it wasnt used for anything

This PR's solution

Remove unused code

Checklist

Check that this PR satisfies the following items:

  • Tests have been added for new features/changed behavior (if no new features have been added, check the box).
  • The changelog file has been updated with a user-readable description of the changes (if the change isn't visible to the user in any way, check the box).
  • The PR's title is prefixed with <feat/fix/chore/imp[rovement]/int[ernal]/docs>[!]:
  • The PR is linked to a JIRA ticket (if there's no suitable ticket, check the box).

@SebastianMorawiec SebastianMorawiec requested a review from a team October 9, 2024 12:22
Copy link

github-actions bot commented Oct 9, 2024

🚀 Code Coverage

-----------------------------------------------------------------------------------------------
src/orquestra/sdk/_client/_base/_api/_task_run.py                   120      8    93%   66, 274-285, 303, 307
src/orquestra/sdk/_client/_base/_api/_wf_run.py                     279     17    94%   121-122, 239-243, 264-265, 372-373, 400, 594, 703-704, 722, 768-769, 788
src/orquestra/sdk/_client/_base/_ast.py                             108      1    99%   222
src/orquestra/sdk/_client/_base/_config/_fs.py                      144      2    99%   339-340
src/orquestra/sdk/_client/_base/_driver/_ce_runtime.py              259      9    97%   71, 212, 217, 478, 633-638, 789
src/orquestra/sdk/_client/_base/_driver/_client.py                  368      8    98%   213-214, 231-232, 240-241, 1140-1141
src/orquestra/sdk/_client/_base/_driver/_models.py                  222      1    99%   577
src/orquestra/sdk/_client/_base/_dsl.py                             427     16    96%   37, 347, 613-622, 1099, 1102-1103, 1111-1112, 1150-1152, 1177, 1192, 1208
src/orquestra/sdk/_client/_base/_factory.py                          26      5    81%   23-25, 40, 53-54
src/orquestra/sdk/_client/_base/_in_process_runtime.py              135     10    93%   104-107, 181-182, 247, 272, 318, 394
src/orquestra/sdk/_client/_base/_services.py                         46     28    39%   17, 20, 23, 26, 48-91, 104-113, 125-135
src/orquestra/sdk/_client/_base/_spaces/_api.py                      28      4    86%   31-32, 57-58
src/orquestra/sdk/_client/_base/_testing/_example_wfs.py            203     80    61%   13, 18-21, 26-29, 34, 44, 49, 54, 60, 81, 92, 104, 110-111, 116-122, 127-132, 137-142, 159, 164-170, 183, 188-191, 196, 201-205, 210, 215, 224-226, 238-243, 250-252, 271-275, 280-281, 286, 291, 315, 346, 356, 361-363, 366, 371, 376-377
src/orquestra/sdk/_client/_base/_testing/_ipc.py                     27     15    44%   14-18, 22-23, 26-29, 32-35, 38-40
src/orquestra/sdk/_client/_base/_testing/resp_mocks.py               70      2    97%   46, 48
src/orquestra/sdk/_client/_base/_traversal.py                       336      7    98%   358, 405, 459, 534, 546, 731, 751
src/orquestra/sdk/_client/_base/_viz.py                              62      5    92%   53-58, 63
src/orquestra/sdk/_client/_base/_workflow.py                        222     18    92%   180-181, 382, 401, 403, 408-412, 541-545, 595-596, 614, 631, 645, 660
src/orquestra/sdk/_client/_base/cli/_arg_resolvers.py               212      4    98%   185, 542-551
src/orquestra/sdk/_client/_base/cli/_config/_list.py                 25      5    80%   35-38, 52
src/orquestra/sdk/_client/_base/cli/_dumpers.py                      60      3    95%   140, 156-157
src/orquestra/sdk/_client/_base/cli/_entry.py                       169     33    80%   136-139, 147-150, 233-236, 275-278, 304-307, 387-390, 401-405, 422-425, 439-442, 472-475, 547-550
src/orquestra/sdk/_client/_base/cli/_login/_login.py                 59      2    97%   81-82
src/orquestra/sdk/_client/_base/cli/_repos.py                       247     13    95%   122-123, 155-156, 323-324, 330, 502-503, 703-704, 723, 866
src/orquestra/sdk/_client/_base/cli/_task/_results.py                30      2    93%   52-53
src/orquestra/sdk/_client/_base/cli/_ui/_click_default_group.py      62      3    95%   150-152
src/orquestra/sdk/_client/_base/cli/_ui/_errors.py                  141     18    87%   72-78, 165, 185-187, 192-194, 199-200, 240-241, 244-245, 250-251
src/orquestra/sdk/_client/_base/cli/_ui/_presenters.py              198      3    98%   51-54, 139
src/orquestra/sdk/_client/_base/cli/_ui/_prompts.py                  89     45    49%   44, 54, 97, 110, 127-136, 145, 154, 181, 191-205, 229-260, 283-299
src/orquestra/sdk/_client/_base/cli/_workflow/_graph.py              44      6    86%   57-58, 86-89
src/orquestra/sdk/_client/_base/cli/_workflow/_list.py               33      2    94%   71-72
src/orquestra/sdk/_client/_base/cli/_workflow/_logs.py               38      2    95%   105-106
src/orquestra/sdk/_client/_base/cli/_workflow/_submit.py             41      5    88%   62-63, 92-94, 127
src/orquestra/sdk/_client/_base/cli/_workflow/_view.py               22      2    91%   45-46
src/orquestra/sdk/_client/_base/loader.py                            64      2    97%   146-147
-----------------------------------------------------------------------------------------------
TOTAL                                                              5275    386    93%

22 files skipped due to complete coverage.
-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
No lines with coverage information in this diff.
-------------

@SebastianMorawiec SebastianMorawiec merged commit 9e3c6d0 into main Oct 9, 2024
12 checks passed
@SebastianMorawiec SebastianMorawiec deleted the Morawiec/proj_dir_remove branch October 9, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants