Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.opentelemetry.io/contrib/instrumentation/runtime from 0.53.0 to 0.58.0 #332

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Bumps go.opentelemetry.io/contrib/instrumentation/runtime from 0.53.0 to 0.58.0.

Release notes

Sourced from go.opentelemetry.io/contrib/instrumentation/runtime's releases.

Release v1.33.0/v0.58.0/v0.27.0/v0.13.0/v0.8.0/v0.6.0/v0.5.0

Overview

Added

  • Added support for providing endpoint, pollingIntervalMs and initialSamplingRate using environment variable OTEL_TRACES_SAMPLER_ARG in go.opentelemetry.io/contrib/samples/jaegerremote. (#6310)
  • Added support exporting logs via OTLP over gRPC in go.opentelemetry.io/contrib/config. (#6340)
  • The go.opentelemetry.io/contrib/bridges/otellogr module. This module provides an OpenTelemetry logging bridge for github.com/go-logr/logr. (#6386)
  • Added SNS instrumentation in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#6388)

Changed

  • Change the span name to be GET /path so it complies with the OTel HTTP semantic conventions in go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho. (#6365)
  • Record errors instead of setting the gin.errors attribute in go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin. (#6346)
  • The go.opentelemetry.io/contrib/config now supports multiple schemas in subdirectories (i.e. go.opentelemetry.io/contrib/config/v0.3.0) for easier migration. (#6412)

Fixed

  • Fix broken AWS presigned URLs when using instrumentation in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#5975)
  • Fixed the value for configuring the OTLP exporter to use grpc instead of grpc/protobuf in go.opentelemetry.io/contrib/config. (#6338)
  • Allow marshaling types in go.opentelemetry.io/contrib/config. (#6347)
  • Removed the redundant handling of panic from the HTML function in go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin. (#6373)
  • The code.function attribute emitted by go.opentelemetry.io/contrib/bridges/otelslog now stores just the function name instead the package path-qualified function name. The code.namespace attribute now stores the package path. (#6415)
  • The code.function attribute emitted by go.opentelemetry.io/contrib/bridges/otelzap now stores just the function name instead the package path-qualified function name. The code.namespace attribute now stores the package path. (#6423)

What's Changed

... (truncated)

Changelog

Sourced from go.opentelemetry.io/contrib/instrumentation/runtime's changelog.

[1.33.0/0.58.0/0.27.0/0.13.0/0.8.0/0.6.0/0.5.0] - 2024-12-12

Added

  • Added support for providing endpoint, pollingIntervalMs and initialSamplingRate using environment variable OTEL_TRACES_SAMPLER_ARG in go.opentelemetry.io/contrib/samples/jaegerremote. (#6310)
  • Added support exporting logs via OTLP over gRPC in go.opentelemetry.io/contrib/config. (#6340)
  • The go.opentelemetry.io/contrib/bridges/otellogr module. This module provides an OpenTelemetry logging bridge for github.com/go-logr/logr. (#6386)
  • Added SNS instrumentation in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#6388)
  • Use a sync.Pool for metric options in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp. (#6394)
  • Added support for configuring Certificate field when configuring OTLP exporters in go.opentelemetry.io/contrib/config. (#6376)

Changed

  • Change the span name to be GET /path so it complies with the OTel HTTP semantic conventions in go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho. (#6365)
  • Record errors instead of setting the gin.errors attribute in go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin. (#6346)
  • The go.opentelemetry.io/contrib/config now supports multiple schemas in subdirectories (i.e. go.opentelemetry.io/contrib/config/v0.3.0) for easier migration. (#6412)

Fixed

  • Fix broken AWS presigned URLs when using instrumentation in go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws. (#5975)
  • Fixed the value for configuring the OTLP exporter to use grpc instead of grpc/protobuf in go.opentelemetry.io/contrib/config. (#6338)
  • Allow marshaling types in go.opentelemetry.io/contrib/config. (#6347)
  • Removed the redundant handling of panic from the HTML function in go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin. (#6373)
  • The code.function attribute emitted by go.opentelemetry.io/contrib/bridges/otelslog now stores just the function name instead the package path-qualified function name. The code.namespace attribute now stores the package path. (#6415)
  • The code.function attribute emitted by go.opentelemetry.io/contrib/bridges/otelzap now stores just the function name instead the package path-qualified function name. The code.namespace attribute now stores the package path. (#6423)
  • Return an error for nil values when unmarshaling NameStringValuePair in go.opentelemetry.io/contrib/config. (#6425)

[1.32.0/0.57.0/0.26.0/0.12.0/0.7.0/0.5.0/0.4.0] - 2024-11-08

Added

  • Add the WithSource option to the go.opentelemetry.io/contrib/bridges/otelslog log bridge to set the code.* attributes in the log record that includes the source location where the record was emitted. (#6253)
  • Add ContextWithStartTime and StartTimeFromContext to go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp, which allows setting the start time using go context. (#6137)
  • Set the code.* attributes in go.opentelemetry.io/contrib/bridges/otelzap if the zap.Logger was created with the AddCaller or AddStacktrace option. (#6268)
  • Add a LogProcessor to go.opentelemetry.io/contrib/processors/baggagecopy to copy baggage members to log records. (#6277)
    • Use baggagecopy.NewLogProcessor when configuring a Log Provider.
      • NewLogProcessor accepts a Filter function type that selects which baggage members are added to the log record.

Changed

  • Transform raw (slog.KindAny) attribute values to matching log.Value types. For example, []string{"foo", "bar"} attribute value is now transformed to log.SliceValue(log.StringValue("foo"), log.StringValue("bar")) instead of log.String("[foo bar"]). (#6254)
  • Upgrade go.opentelemetry.io/otel/semconv/v1.17.0 to go.opentelemetry.io/otel/semconv/v1.21.0 in go.opentelemetry.io/contrib/instrumentation/go.mongodb.org/mongo-driver/mongo/otelmongo. (#6272)
  • Resource doesn't merge with defaults if a valid resource is configured in go.opentelemetry.io/contrib/config. (#6289)

... (truncated)

Commits
  • f6667f6 Release v1.33.0/v0.58.0/v0.27.0/v0.13.0/v0.8.0/v0.6.0/v0.5.0 (#6435)
  • 741c472 config: add support for certificate configuration (#6376)
  • 0c0b385 Add method and benchmarks for pooling metric options (#6394)
  • 378d704 config: fix panic on nil value in headers name/value pair (#6425)
  • 1606707 chore(deps): update module github.com/goccy/go-json to v0.10.4 (#6430)
  • 3160376 fix(deps): update module github.com/labstack/echo/v4 to v4.13.2 (#6433)
  • 271162e chore(deps): update module sigs.k8s.io/structured-merge-diff/v4 to v4.5.0 (#6...
  • dc41d0e chore(deps): update k8s.io/kube-openapi digest to 5ad02ce (#6432)
  • a71bdc8 otelzap: Split code attributes (#6423)
  • cb458f1 chore(deps): update module golang.org/x/crypto to v0.31.0 (#6426)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [go.opentelemetry.io/contrib/instrumentation/runtime](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.53.0 to 0.58.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.53.0...zpages/v0.58.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 16, 2024
@zapier-sre-bot
Copy link
Collaborator

Mergecat's Review

Click to read mergecats review!

😼 Mergecat review of go.mod

@@ -20,6 +20,7 @@ require (
 	github.com/go-git/go-git-fixtures/v4 v4.3.2-0.20231010084843-55a94097c399
 	github.com/go-logr/zerologr v1.2.3
 	github.com/google/go-github/v62 v62.0.0
+	github.com/google/uuid v1.6.0
 	github.com/heptiolabs/healthcheck v0.0.0-20211123025425-613501dd5deb
 	github.com/imdario/mergo v0.3.16
 	github.com/jeremywohl/flatten v1.0.1
@@ -40,17 +41,17 @@ require (
 	github.com/spf13/cobra v1.8.1
 	github.com/spf13/pflag v1.0.5
 	github.com/spf13/viper v1.19.0
-	github.com/stretchr/testify v1.9.0
+	github.com/stretchr/testify v1.10.0
 	github.com/xanzy/go-gitlab v0.109.0
 	github.com/yannh/kubeconform v0.6.4
 	github.com/ziflex/lecho/v3 v3.7.0
-	go.opentelemetry.io/contrib/instrumentation/runtime v0.53.0
-	go.opentelemetry.io/otel v1.32.0
+	go.opentelemetry.io/contrib/instrumentation/runtime v0.58.0
+	go.opentelemetry.io/otel v1.33.0
 	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.32.0
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.32.0
-	go.opentelemetry.io/otel/sdk v1.32.0
-	go.opentelemetry.io/otel/sdk/metric v1.32.0
-	go.opentelemetry.io/otel/trace v1.32.0
+	go.opentelemetry.io/otel/sdk v1.33.0
+	go.opentelemetry.io/otel/sdk/metric v1.33.0
+	go.opentelemetry.io/otel/trace v1.33.0
 	golang.org/x/exp v0.0.0-20240112132812-db7319d0e0e3
 	golang.org/x/net v0.30.0
 	golang.org/x/oauth2 v0.24.0
@@ -84,7 +85,6 @@ require (
 	github.com/Microsoft/go-winio v0.6.2 // indirect
 	github.com/OneOfOne/xxhash v1.2.8 // indirect
 	github.com/ProtonMail/go-crypto v1.0.0 // indirect
-	github.com/TomOnTime/utfutil v0.0.0-20180511104225-09c41003ee1d // indirect
 	github.com/agext/levenshtein v1.2.3 // indirect
 	github.com/agnivade/levenshtein v1.1.1 // indirect
 	github.com/anchore/go-struct-converter v0.0.0-20221118182256-c68fdcfa2092 // indirect
@@ -158,7 +158,6 @@ require (
 	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/google/s2a-go v0.1.7 // indirect
 	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
-	github.com/google/uuid v1.6.0 // indirect
 	github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect
 	github.com/googleapis/gax-go/v2 v2.12.3 // indirect
 	github.com/gorilla/mux v1.8.1 // indirect
@@ -264,17 +263,18 @@ require (
 	github.com/yuin/gopher-lua v1.1.1 // indirect
 	github.com/zclconf/go-cty v1.13.2 // indirect
 	go.opencensus.io v0.24.0 // indirect
+	go.opentelemetry.io/auto/sdk v1.1.0 // indirect
 	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.55.0 // indirect
 	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.53.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.32.0 // indirect
-	go.opentelemetry.io/otel/metric v1.32.0 // indirect
+	go.opentelemetry.io/otel/metric v1.33.0 // indirect
 	go.opentelemetry.io/proto/otlp v1.3.1 // indirect
 	go.starlark.net v0.0.0-20231121155337-90ade8b19d09 // indirect
 	go.uber.org/automaxprocs v1.5.3 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
 	golang.org/x/crypto v0.28.0 // indirect
 	golang.org/x/sync v0.9.0 // indirect
-	golang.org/x/sys v0.27.0 // indirect
+	golang.org/x/sys v0.28.0 // indirect
 	golang.org/x/term v0.25.0 // indirect
 	golang.org/x/text v0.20.0 // indirect
 	golang.org/x/time v0.6.0 // indirect

Feedback & Suggestions:

  1. Duplicate Dependency: The addition of github.com/google/uuid v1.6.0 as a direct dependency while it was already present as an indirect dependency can lead to confusion. Ensure that the dependency is required directly by your code. If not, consider removing the direct requirement to avoid redundancy. 🌀

  2. Version Updates: The updates to go.opentelemetry.io packages are generally good for keeping up with the latest features and fixes. However, ensure that these updates are compatible with your existing codebase and do not introduce breaking changes. Consider running tests to verify compatibility. 🔄

  3. Removed Indirect Dependency: The removal of github.com/TomOnTime/utfutil as an indirect dependency is fine if it's no longer needed. Double-check that no part of your codebase or other dependencies rely on it. 🗑️

  4. Indirect Dependency Version Change: The update of golang.org/x/sys from v0.27.0 to v0.28.0 should be verified for compatibility with your codebase, as changes in system-level packages can sometimes have unexpected impacts. ⚙️

  5. New Indirect Dependency: The addition of go.opentelemetry.io/auto/sdk v1.1.0 as an indirect dependency should be reviewed to ensure it aligns with your project's goals and does not introduce unnecessary bloat. 📦



Dependency Review

Click to read mergecats review!

No suggestions found

Copy link

github-actions bot commented Dec 16, 2024

Temporary image deleted.

@djeebus djeebus merged commit a404abb into main Dec 16, 2024
5 checks passed
@djeebus djeebus deleted the dependabot/go_modules/go.opentelemetry.io/contrib/instrumentation/runtime-0.58.0 branch December 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants