Improve User lookup performance (fixes issue #29) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code always tried to retrieve the underlying mapiobj. This is not always needed and may involve multiple network round-trips. Therefore, this commit lazy-loads the mapiobj instance so that simple user attribute retrieval can be executed without loading this object at all.
|
looks good, thanks! we probably have more such cases, where we do too much work in init. btw looping over folders (Folder.folders()) is probably also still quite slow atm.. ;-) |
|
Thanks for the PR, we will merge this change when the Github repo is up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code always tried to retrieve the underlying mapiobj.
This is not always needed and may involve multiple network round-trips.
Therefore, this commit lazy-loads the mapiobj instance so that simple
user attribute retrieval can be executed without loading this object
at all.