Ultralib Update #233
Draft
Ultralib Update #233
+3,692
−1,924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrepo: subdir: "lib/ultralib" merged: "74f0eee" upstream: origin: "[email protected]:decompals/ultralib.git" branch: "main" commit: "2717d45" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "cce3d93"
|
Seems like the ultralib update introduced new warnings |
|
Ahh, its mainly the new kmcprintf which shouldn't even be building tbh. I've created a PR in ultralib to fix that. The other ones have to do with different line numbers due to added comments in asm files. |
|
Drafting until ultralib gets updated to not build kmcprintf for non debug versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ultralib to current main. The main thing is ultralib now has the correct prototypes for print functions, so explicit casts are no longer needed as well as moving some internal PR includes to easier to access headers. Also comes with some newer documentation, and comes with the ability to build using modern gcc if desired.