-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support build options via npmrc #633
Conversation
I'm not too familiar with building native node modules but this gives a reference for how to target multiple architectures at once. https://sharp.pixelplumbing.com/install#cross-platform I think I saw a reference for specifying universal builds for macOS in Cmake via |
557ff8b
to
7ae51ce
Compare
We probably don't need that for prebuilds, but if someone desires that now it's possible via the |
Yes, how does this interact with https://yarnpkg.com/configuration/yarnrc#supportedArchitectures |
That's a feature that we don't support yet, and we might look into it. It's quite complicated, and unless a package provides it, I am not sure if it is worth it. |
I don’t know what you mean “unless a package provides it”. The way esbuild supports being installed on multiple architectures is based on splitting the prebuilds across several packages. It would be complicated even if they didn’t support multiple architectures. I believe the way pnpm and yarn support this is by calling the
|
We're using Node's native way, which is the
The code for handling what Esbuild does. There's a lot of management to be done if we want to support that. |
This makes it possible to specify the build options of zeromq through npmrc.
They are documented here:
https://github.com/zeromq/zeromq.js/tree/opts#draft-support
Related to #529