Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option 'parseMultipartMixedTextAttachmentsAsFiles' to ezcMailParserOptions #96

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

derickr
Copy link
Member

@derickr derickr commented Nov 5, 2024

No description provided.

… to ezcMailParserOptions

By setting this option like:

  $parser = new ezcMailParser();
  $parser->options->parseMultipartMixedTextAttachmentsAsFiles = true;

The parser returns text parts as attachments, but only if they are sub-parts of
multipart/mixed parts.

This is distinct from the 'parseTextAttachmentsAsFiles' option, which does it
for *all* text parts.
@derickr derickr changed the title Add test for PR #95 Add new option 'parseMultipartMixedTextAttachmentsAsFiles' to ezcMailParserOptions Nov 6, 2024
@derickr
Copy link
Member Author

derickr commented Nov 7, 2024

Ping @eileenmcnaughton @seamuslee001 :-)

@eileenmcnaughton
Copy link
Contributor

thank you @derickr - you are amazing

I have applied this locally & our unit test still passes with it so it all looks good - I'm just waiting on our full test suite to run civicrm/civicrm-core#31450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants