bugfix for on_setattr (#15)

zincware · Dec 14, 2022 · 4e6b824 · 4e6b824
1 parent 8a058cc
commit 4e6b824
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tests/test_descriptor.py b/tests/test_descriptor.py
@@ -184,8 +184,8 @@ def test_descriptor_metadata():
 class WithSetAttr:
     """Modify the value before saving it."""
 
-    value = Descriptor(on_setattr=lambda self, value: value + 1)
-    value_frozen = Descriptor(frozen=True, on_setattr=lambda self, value: value + 1)
+    value = Descriptor(on_setattr=lambda value: value + 1)
+    value_frozen = Descriptor(frozen=True, on_setattr=lambda value: value + 1)
 
 
 def test_with_setattr():

diff --git a/zninit/descriptor/__init__.py b/zninit/descriptor/__init__.py
@@ -170,7 +170,7 @@ def __set__(self, instance, value):
         if self._frozen.get(instance, False):
             raise TypeError(f"Frozen attribute '{self.name}' can not be changed.")
         if self.on_setattr is not None:
-            value = self.on_setattr(instance, value)
+            value = self.on_setattr(value)
         if self.check_types:
             typeguard.check_type(
                 argname=self.name, value=value, expected_type=self.annotation