Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type for executeAction #2907

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mkemaldurmus
Copy link

@mkemaldurmus mkemaldurmus commented Oct 2, 2023

Fixes #issue_number

Problem

I've been using executeQuery when writing raw queries in Cassandra, but it uses the execute function, which means it operates synchronously. I want to use executeAction because it uses executeAsync. The problem is that executeAction returns Unit,

Solution

return AsyncResultSet instead of Unit

Notes

Additional notes.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ mkemaldurmus
✅ juliano
✅ guizmaii
❌ kemal durmuş


kemal durmuş seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mkemaldurmus mkemaldurmus marked this pull request as draft October 2, 2023 18:03
@mkemaldurmus mkemaldurmus changed the title Add return type executeAction Add return type for executeAction Oct 2, 2023
@guizmaii
Copy link
Member

guizmaii commented Oct 3, 2023

@mkemaldurmus Thanks for your work.
You'll also need to sign the ZIO CLA for us to be able to merge your work. See #2907 (comment)

@mkemaldurmus mkemaldurmus force-pushed the add-return-type branch 2 times, most recently from d1040a6 to 99e3a4c Compare October 5, 2023 08:42
@mkemaldurmus mkemaldurmus marked this pull request as ready for review October 27, 2023 13:01
@mkemaldurmus
Copy link
Author

@guizmaii done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants