-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #862: Improve reconnect error page. #1292
base: main
Are you sure you want to change the base?
Conversation
@zulipbot claim |
Hello @tarun-kanojia! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
@zulipbot add "good first issue" |
@zulipbot "help wanted" |
Hey @timabbott the issue seems to persist on the last version of Zulip. Can you please give a review on the changes I made? |
@zulipbot claim |
Hello @mdaatifayman786! Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
2e81397
to
7f3c1c8
Compare
Hi @timabbott this PR is currently up to date with the main and fixes #862 (seems to be still open) can you give a review please? |
Can I be assigned this issue if it is still unsolved? |
What's this PR do?
Fixed image scaling problem when resizing screen and buttons' position is aligned with texts at all possible window sizes.
Screenshots?
You have tested this PR on: