Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #862: Improve reconnect error page. #1292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enesonus
Copy link


What's this PR do?
Fixed image scaling problem when resizing screen and buttons' position is aligned with texts at all possible window sizes.

Screenshots?
ezgif-2-79b66698f3

You have tested this PR on:

  • Windows
  • Linux/Ubuntu
  • macOS

@enesonus enesonus changed the title Fixes #862 Fixes #862: Improve reconnect error page. Apr 2, 2023
@tarun-kanojia
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 5, 2023

Hello @tarun-kanojia!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@tarun-kanojia
Copy link

tarun-kanojia commented Apr 5, 2023

@zulipbot add "good first issue"

@tarun-kanojia
Copy link

@zulipbot "help wanted"

@enesonus
Copy link
Author

Hey @timabbott the issue seems to persist on the last version of Zulip. Can you please give a review on the changes I made?

@mdaatifayman786
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @mdaatifayman786!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

'texts' div id to 'network-error-texts'
@enesonus enesonus force-pushed the new-reconnect-error-page branch from 2e81397 to 7f3c1c8 Compare January 27, 2024 13:42
@enesonus
Copy link
Author

Hi @timabbott this PR is currently up to date with the main and fixes #862 (seems to be still open) can you give a review please?

@chandanSahoo-cs
Copy link

Can I be assigned this issue if it is still unsolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants