nav: Add an About Zulip button to the main menu

[tomlin7]

fix #1128

Changes

• Added About Zulip button to main menu
• Added localizations and tests for the button

Screenshots

---

outdated screenshot (icon changed):

zulip.mp4

The tests are passing:

[chrisbobbe]

Thanks! Small comments below.

The other thing this PR needs is screenshots. Please include screenshots of the new button in the PR description.

[tomlin7]

@chrisbobbe I have made the code changes and added screenshots! please check

[chrisbobbe]

I see a video; please include a still image because videos are harder to review.

[chrisbobbe]

For which icon to use, let's use the same icon that web uses for a similar button:

Looks like that's this SVG file: https://github.com/zulip/zulip/blob/74d7f1192/web/shared/icons/info.svg

Please add that file to the project in a separate prep commit, using the instructions in lib/widgets/icons.dart. The commit message should say that we didn't find a suitable icon in the Icons page of the Figma design (with a link to that page), which is why we're using the one from web. The commit should include this link, which points to the SVG file in web: https://github.com/zulip/zulip/blob/74d7f1192/web/shared/icons/info.svg

[tomlin7]

@chrisbobbe I have added a still image of the About Zulip button as well. Please check now.

[chrisbobbe]

Great, thanks! I see it's not the icon from the web app that I mentioned in my comment above: #1157 (comment)

Please update the PR with that change. 🙂

[tomlin7]

@chrisbobbe Pardon, I saw the second message after sending previous one!
I have the changes ready, how would I go about making a separate preparatory commit? Do I just push to the same branch with a new commit?

[tomlin7]

@chrisbobbe After reading more docs, and having an understanding of what to do, I have done a separate commit because it's an entirely different kind of change compared to previous ones. Also updated screenshots, please review!

[apoorvapendse]

Hey @tomlin7, the test you added seems to be failing

[tomlin7]

@apoorvapendse thanks for pointing this out! I have fixed the test now, please review it.

[chrisbobbe]

Thanks, this is quite close! Please switch the order of the two commits: the commit adding the icon should come first, so the new button uses it from the beginning.

You can use an interactive rebase to reorder the commits. If you need help, please ask on #git help in the Zulip development community.

[tomlin7]

@chrisbobbe I have reordered the commits, thanks for the docs. Please check!

[chrisbobbe]

Thanks! LGTM; marking for Greg's review.

[gnprice]

Thanks @tomlin7 for the contribution! And thanks @chrisbobbe for the previous reviews.

Generally this looks good. Small comments below.

[tomlin7]

@gnprice I have fixed the commit messages and fixed the redundancy as well! please check.
I'm really not sure if the tests are failing due to the change made.

[gnprice]

Thanks for the revision! All LGTM.

The CI failure looks like #1177. I've rebased, and tools/check passes for me locally — merging.

(CI will take a few minutes longer because it runs tools/check --all, including things like building an APK which are very unlikely to be affected by this change.)