Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db [nfc]: Remove handwritten copy of copyWithCompanion #1166

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Dec 16, 2024

This has been addressed in Greg's upstream PR: simolus3/drift#3022

@chrisbobbe
Copy link
Collaborator

Thanks! LGTM, marking for Greg's review.

@chrisbobbe chrisbobbe assigned gnprice and unassigned chrisbobbe Dec 19, 2024
@chrisbobbe chrisbobbe requested review from gnprice and removed request for gnprice December 19, 2024 00:44
@chrisbobbe chrisbobbe added the integration review Added by maintainers when PR may be ready for integration label Dec 19, 2024
This has been addressed in Greg's upstream PR:
  simolus3/drift#3022

which was pulled in by the Drift upgrade in 8b564e4 (zulip#1117).

Signed-off-by: Zixuan James Li <[email protected]>
@gnprice gnprice merged commit 59c6ef6 into zulip:main Dec 19, 2024
@gnprice
Copy link
Member

gnprice commented Dec 19, 2024

Thanks! Looks good; merging, after adding a bit more context to the commit message:

which was pulled in by the Drift upgrade in 8b564e4 (#1117).

@PIG208 PIG208 deleted the pr-drift branch December 19, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants