Migrate internal code to use Direct Message terminology

[Ajnus]

What does this PR do, and why?

Replaces instances of:
private, privates, _ private, private _, PRIVATE, PRIVATES, Private , pm, pms, _ pm, pm _, PM, Pm
(and derivatives, e.g: _is_private_message_to_self, private_msg_ids, private_msg_ids_by_user_ids, (...))

to Direct Message terminology, avoiding the test_model.py, model.py files, strings and other instances related to the API, for API consistency reasons, while "exploring other parts", such as replacing comments.

This PR consists of the - on-chat debated - first part of altering just internal code, not the second that focus on API related code.

External discussion & connections

• Discussed in #zulip-terminal in #T1344 Migrate internal code to use Direct Message terminology
• Fully fixes TRACKING: Migrate internal code to use Direct Message terminology #1344
• [] Partially fixes issue #
• Builds upon previous unmerged work in PR TRACKING: Migrate internal code to use Direct Message terminology #1344
• Is a follow-up to work in PR #
• Requires merge of PR #
• Merge will enable work on #

How did you test this?

• Manually - Behavioral changes
• Manually - Visual changes
• Adapting existing automated tests
• Adding automated tests for new behavior (or missing tests)
• Existing automated tests should already cover this (only a refactor of tested code)
• It runs
  

Self-review checklist for each commit

• It is a minimal coherent idea
• It has a commit summary following the documented style (title & body)
• It has a commit summary describing the motivation and reasoning for the change
• It individually passes linting and tests
• It contains test additions for any new behavior
• It flows clearly from a previous branch commit, and/or prepares for the next commit

[rsashank]

@Ajnus Thanks for working on this! I haven’t reviewed the changes in detail.

But in the tests, ZT relies on gitlint to enforce specific commit message rules. The README includes setup instructions for adding a gitlint commit-message hook, which lets you test locally and ensure your commit messages follow the required format.

While your commit messages generally look good, they don’t fully comply with gitlint’s formatting rules.

[rsashank]

Additionally, avoid using separate commits solely to fix test issues. Every test must pass on each commit since the Linting & tests / Ensure isolated PR commits (pull_request) check ensures that all commits stand alone successfully.

Maybe try rebasing to correct issues in each commit as needed.

For example:

In the commit Refactor: replace 'PM' with 'DM' (ignoring model.py, test_model.py, f…), isort is not satisfied (which you fixed in this commit separately). Rebase, address this, and make sure each commit individually passes all tests.

[Ajnus]

My pleasure @rsashank 🫡
Indeed, the Linting & tests / Lint - Commit text format (gitlint) (pull_request) was, at the time, the last test that needed a fixing - which I just did. :)

However, by fixing it - maybe that's just how it happens, still a newcomer into contributing don't really know yet - from 2 other tests that were skipped, now Linting & tests / Ensure isolated PR commits (pull_request) do tests, and fails - the other last test still skipped, probably one test depends on the other and so on I imagine - so, the 1 commit per test passed was more a (yesterday) deadline (presentation) issue, although this structure does help me track which tests are good - even because from what I understand the tests only (re)run after a push to the repository is made - and which are not.
But overall in the end I'll just squash everything to what's better for you guys.

Stay tuned for the next episodes. =]

[rsashank]

Got it! I just thought some clarification might be helpful since I assumed you were new to this. My mistake if I jumped in too early!

Good luck :)

[neiljp]

@Ajnus Just a quick note re testing in general - these can all be run locally, as per the development notes in the README. In particular there is tools/check-branch, for the isolated commit check itself.

[zulipbot]

Hello @Ajnus, it seems like you have referenced #1344 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #1344..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

[Ajnus]

Hello @Ajnus, it seems like you have referenced #1344 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #1344..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

Doesn't this breaks
@github-actions
Linting & tests / Lint - Commit text format (gitlint) (pull_request) ?

[Ajnus]

@Ajnus Just a quick note re testing in general - these can all be run locally, as per the development notes in the README. In particular there is tools/check-branch, for the isolated commit check itself.

Can't really. Even after make test

[timabbott]

@Ajnus the commit history needs to be cleaned up before this will be ready for review. Check out our GitHub guide and commit guidelines for more details.

[Ajnus]

@timabbott check the zulip chat please.