Restrict user from claiming a pull request. #231
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 64.04% 64.25% +0.21%
==========================================
Files 23 23
Lines 1741 1757 +16
==========================================
+ Hits 1115 1129 +14
- Misses 626 628 +2 |
config/templates/claimPullRequest.md
Outdated
|
|
||
| Thanks for your interest in Zulip! Please note that claiming pull requests is not supported. You can exclusively claim and submit pull requests for issues bearing the [help wanted](https://github.com/{repoOwner}/{repoName}/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22help+wanted%22) label. | ||
|
|
||
| If this is your first time here, we recommend reading our [guide for new contributors](https://zulip.readthedocs.io/en/latest/overview/contributing.html) before getting started. |
There was a problem hiding this comment.
Let's make it:
Hello @{commenter}!
You have attempted to claim a pull request, which is someone else's proposed solution for an issue. Please review our guide for new contributors to learn how to find an issue to work on.
|
I've updated the texts per your suggestions. Please take another look and let me know if any other changes are needed. |
|
Thanks! @andersk are you the right person to review this PR? |
|
@timabbott are you up for reviewing? |
|
The first commit will crash without the second, so it is not a coherent logical unit. The two commits need to be squashed together. |
Earlier response for claiming an issue and pull request was same, this commit restricts contributors from claiming a pull request. tests: Add test scenario for pull request claim attempt. template: Add new message for pull request claim. Signed-off-by: sayyedarib <[email protected]>
|
Thanks @sayyedarib, this is live now. |
CZO thread