Librarify index.js, so that existing express apps can be re-used #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to self-host this, but preferably on my existing express instance so that I can continue to use the same port. To that end, I moved the bulk of the code into a new
utils.jsand wrapped it in two functions:getExpressRoutes(), which optionally takes in config for endpoint URLs, clientId/secret, host, and port, and returns a function with a dictionary{ [endpoint: 'oauth' | 'tokenRefresh' | 'render'] : { route: string, callbacks: Function[] } }that a consumer can plug into their own express instance.configureApp()which callsgetExpressRoutes()and adds them to an express instance -- which can be passed in, or else one is made for the caller.