Slightly changes syntax of PyOpenGL EGL code to be more correct #574
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
While I still think this is a worthwhile change since it passes args more correctly. It seems to make no change to the functionality somehow. I'll continue to try to figure out the cause of #573 |
mishmish66
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This
fixes issue #573 which I introduced because Ipassed the argumentEGLConfig * configsdirectly instead of by reference toeglChooseConfigHow it was tested
Ran pytest with python 3.11 and 3.12 and used offscreen rendering while running large deep learning tasks
How to checkout & try? (for the reviewer)
Use a lot of VRAM with pytorch and try offscreen rendering