Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e test file upload step #2546

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

programmiri
Copy link
Contributor

@programmiri programmiri commented Aug 7, 2024

  • makes sure artefacts for playwright tests are always uploaded

I did commit and run a failing test to make sure this works, too! :D (but remove the commit again of course)
(here's the failing pipeline from that run: https://github.com/Aiven-Open/klaw/actions/runs/10287488148/job/28470625125)

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Docs update
  • CI update

What is the current behavior?

Describe the state of the application before this PR. Illustrations appreciated (videos, gifs, screenshots).

What is the new behavior?

Describe the state of the application after this PR. Illustrations appreciated (videos, gifs, screenshots).

Other information

Additional changes, explanations of the approach taken, unresolved issues, necessary follow ups, etc.

Requirements (all must be checked before review)

  • The pull request title follows our guidelines
  • Tests for the changes have been added (if relevant)
  • The latest changes from the main branch have been pulled
  • pnpm lint has been run successfully

@programmiri programmiri force-pushed the update-e2e-test-pipeline branch 3 times, most recently from d46cf81 to c911220 Compare August 7, 2024 15:53
@programmiri programmiri self-assigned this Aug 7, 2024
@programmiri programmiri marked this pull request as ready for review August 7, 2024 15:54
Signed-off-by: Mirjam Aulbach <[email protected]>
@programmiri programmiri force-pushed the update-e2e-test-pipeline branch from c911220 to f307f05 Compare August 19, 2024 12:38
Copy link
Contributor

@aindriu-aiven aindriu-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aindriu-aiven aindriu-aiven merged commit 0fdec2d into main Aug 20, 2024
21 of 22 checks passed
@aindriu-aiven aindriu-aiven deleted the update-e2e-test-pipeline branch August 20, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants