Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add concatenate datasets method #148

Merged
merged 4 commits into from
Aug 20, 2024
Merged

add concatenate datasets method #148

merged 4 commits into from
Aug 20, 2024

Conversation

kai-car
Copy link
Collaborator

@kai-car kai-car commented Aug 8, 2024

Implementing a method for the concatenation of multiple datasets into one single dataset.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (8605432) to head (2d9506e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   92.02%   92.19%   +0.16%     
==========================================
  Files          10       10              
  Lines         878      897      +19     
==========================================
+ Hits          808      827      +19     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kai-car kai-car marked this pull request as draft August 8, 2024 07:53
@kai-car kai-car self-assigned this Aug 8, 2024
@kai-car kai-car marked this pull request as ready for review August 9, 2024 08:53
@kai-car kai-car requested a review from ArneBinder August 9, 2024 08:53
kai-car and others added 3 commits August 20, 2024 21:06
* enables concatenation of multiple pie-datasets

* tests still missing
* testing the core functionality with list/dic of Dataset/IterableDatasets
 through test_concatenate_datasets()

* testing occurring errors during concatenation through test_concatenate_datasets_errors()

* testing helper function _add_dset_name_to_document
@ArneBinder ArneBinder added the enhancement New feature or request label Aug 20, 2024
Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ArneBinder ArneBinder merged commit b18e37f into main Aug 20, 2024
4 checks passed
@ArneBinder ArneBinder deleted the concat-datasets branch August 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants