Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height to dropdown #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add height to dropdown #233

wants to merge 2 commits into from

Conversation

ShreeramBhat
Copy link

Added height to the drop down. If there is no height, it will act just like before. Usage is like

dropDown.height = (data.count > 5) ? (dropDown.cellHeight * 5) : (dropDown.cellHeight * data.count)

SaadTahir28
SaadTahir28 approved these changes May 16, 2019
View reviewed changes
Copy link

@SaadTahir28 SaadTahir28 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 590 needs to be commented as line 588 is being used.

@ShreeramBhat
Copy link
Author

Removed 590th extra line. Sorry this thing happened because I added and tested height feature inside my personal project and copy and pasted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaadTahir28 SaadTahir28 SaadTahir28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShreeramBhat @SaadTahir28