Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add height to dropdown #233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add height to dropdown #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e05a80
Add height to dropdown
ShreeramBhat May 14, 2019
1a6e97e
Removed extra scrolling enabled line
ShreeramBhat May 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions DropDown/src/DropDown.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,15 @@ public final class DropDown: UIView {
public var width: CGFloat? {
didSet { setNeedsUpdateConstraints() }
}

/**
The height of the drop down.

Defaults to `tableHeight - offscreenHeight`.
*/
public var height: CGFloat? {
didSet { setNeedsUpdateConstraints() }
}

/**
arrowIndication.x
Expand Down Expand Up @@ -567,9 +576,16 @@ extension DropDown {
xConstraint.constant = layout.x
yConstraint.constant = layout.y
widthConstraint.constant = layout.width
heightConstraint.constant = layout.visibleHeight

tableView.isScrollEnabled = layout.offscreenHeight > 0

// Change height of dropdown
if height != nil && (height ?? 0) <= layout.visibleHeight {
heightConstraint.constant = height!
} else {
heightConstraint.constant = layout.visibleHeight
}

// Enable scrolling if offscreen content or height is set
tableView.isScrollEnabled = layout.offscreenHeight > 0 || (height ?? 0) > 0

DispatchQueue.main.async { [weak self] in
self?.tableView.flashScrollIndicators()
Expand Down Expand Up @@ -697,7 +713,7 @@ extension DropDown {
constraintWidthToFittingSizeIfNecessary(layout: &layout)
constraintWidthToBoundsIfNecessary(layout: &layout, in: window)

let visibleHeight = tableHeight - layout.offscreenHeight
let visibleHeight = height ?? (tableHeight - layout.offscreenHeight)
let canBeDisplayed = visibleHeight >= minHeight

return (layout.x, layout.y, layout.width, layout.offscreenHeight, visibleHeight, canBeDisplayed, direction)
Expand All @@ -707,14 +723,15 @@ extension DropDown {
var offscreenHeight: CGFloat = 0

let width = self.width ?? (anchorView?.plainView.bounds.width ?? fittingWidth()) - bottomOffset.x
let height = self.height ?? tableHeight

let anchorViewX = anchorView?.plainView.windowFrame?.minX ?? window.frame.midX - (width / 2)
let anchorViewY = anchorView?.plainView.windowFrame?.minY ?? window.frame.midY - (tableHeight / 2)
let anchorViewY = anchorView?.plainView.windowFrame?.minY ?? window.frame.midY - (height / 2)

let x = anchorViewX + bottomOffset.x
let y = anchorViewY + bottomOffset.y

let maxY = y + tableHeight
let maxY = y + height
let windowMaxY = window.bounds.maxY - DPDConstant.UI.HeightPadding - offsetFromWindowBottom

let keyboardListener = KeyboardListener.sharedInstance
Expand All @@ -736,7 +753,7 @@ extension DropDown {
let anchorViewMaxY = anchorView?.plainView.windowFrame?.maxY ?? 0

let x = anchorViewX + topOffset.x
var y = (anchorViewMaxY + topOffset.y) - tableHeight
var y = (anchorViewMaxY + topOffset.y) - (height ?? tableHeight)

let windowY = window.bounds.minY + DPDConstant.UI.HeightPadding

Expand Down