feature/#398-expand-exposed-type-parameter

[sohamkumar05]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

We are also including pandas.DataFrame and numpy.ndarray as exposed type.

Related Tickets & Documents

• Related Issue Expand the exposed_type parameter of DataNode to accept actual Python types #398
• Closes Expand the exposed_type parameter of DataNode to accept actual Python types #398

How to reproduce the issue

Checklist

We encourage you to keep the code coverage percentage at 80% and above.

• Does this solution meet the acceptance criteria of the related issue?
• Is the related issue checklist completed?
• Does this PR adds unit tests for the developed code? If not, why?
• End-to-End tests have been added or updated?
• Was the documentation updated, or a dedicated issue for documentation created? (If applicable)
• Is the release notes updated? (If applicable)

[trgiangdo]

Thank you @sohamkumar05 for your contribution with the Pull Request.

I believe the PR is in a good shape. There are a few refinements needed, and then the Taipy team will do some testing before we can merge your PR.

[trgiangdo]

The PR looks good to me. I believe it's almost ready to be merged.

I have 1 more request just to make sure this works properly with Taipy serialization.

Can you write a few test cases exploring cases where instead of import pandas as pd and use pd.DataFrame as the exposed_type, do:

• import pandas and use pandas.DataFrame
• from pandas import DataFrame and use just the DataFrame
• from pandas import DataFrame as DF and use DF

Similarly, try different imports for np.ndarray

[sohamkumar05]

The PR looks good to me. I believe it's almost ready to be merged.

I have 1 more request just to make sure this works properly with Taipy serialization.

Can you write a few test cases exploring cases where instead of import pandas as pd and use pd.DataFrame as the exposed_type, do:

• import pandas and use pandas.DataFrame
• from pandas import DataFrame and use just the DataFrame
• from pandas import DataFrame as DF and use DF

Similarly, try different imports for np.ndarray

I made the changes for the same. The test cases work fine. Although I cannot push my change as I am getting this issue on pre-commit, which I do not think so makes sense to me
`

git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
mypy.....................................................................Passed
CRLF end-lines checker...................................................Passed
CRLF end-lines remover...................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Insert license in comments...............................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check yaml...........................................(no files to check)Skipped
ruff.....................................................................Passed
ruff-format..............................................................Passed
codespell................................................................Failed

• hook id: codespell
• exit code: 65

tests/core/data/test_csv_data_node.py:206: nd ==> and, 2nd
tests/core/data/test_csv_data_node.py:209: nd ==> and, 2nd
tests/core/data/test_csv_data_node.py:210: nd ==> and, 2nd
tests/core/data/test_excel_data_node.py:389: nd ==> and, 2nd
tests/core/data/test_excel_data_node.py:393: nd ==> and, 2nd
tests/core/data/test_excel_data_node.py:395: nd ==> and, 2nd
tests/core/data/test_excel_data_node.py:397: nd ==> and, 2nd
`

Why do I need to change from numpy import ndarray as nd to something like that?

[trgiangdo]

The codespell job is trying to find misspelled words, and it mistakingly considers your nd as a misspelled word.

You can try something else, like from numpy import ndarray as ND_Array, or literally anything from ndarray, just so we can test it out.

[trgiangdo]

Thank you @sohamkumar05 for your contribution.

I believe the PR is looking good now. Thank you.