Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant \currentpdfbookmark for English bachelor thesis #522

Merged
merged 3 commits into from
May 28, 2024

Conversation

CreeperLKF
Copy link
Contributor

  • 在本科全英文模板编译出的PDF书签中,会同时出现"目录"和"Table of Content",似乎是 fix: better bookmark #480 引入的Bug。
    image

  • 在全英文模板main.tex中添加了title属性,以此在中文摘要中输出正确标题。修复了样例中的"Bachelor"拼写错误。

@YDX-2147483647 YDX-2147483647 changed the title fix: remove redundant \currentpdfbookmark\ for English bachelor thesis fix: remove redundant currentpdfbookmark\ for English bachelor thesis May 28, 2024
@YDX-2147483647 YDX-2147483647 changed the title fix: remove redundant currentpdfbookmark\ for English bachelor thesis fix: remove redundant \currentpdfbookmark for English bachelor thesis May 28, 2024
Copy link
Collaborator

@YDX-2147483647 YDX-2147483647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢!

我试了make regression-test,确实只有英文模板封面的 Bachelor 和中文摘要标题有变化。

此外,中文模板“目录”指向目录那页的下半部分,不太对劲;不过之前似乎也这样,恐怕属于玄学。

@fky2015 fky2015 added this pull request to the merge queue May 28, 2024
Merged via the queue into BITNP:main with commit 9e1f0e4 May 28, 2024
3 checks passed
YDX-2147483647 added a commit to YDX-2147483647/BIThesis that referenced this pull request Jul 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants