Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant \currentpdfbookmark for English bachelor thesis #522

Merged
merged 3 commits into from
May 28, 2024
Merged

fix: remove redundant \currentpdfbookmark for English bachelor thesis #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4afad01
fix: remove redundant `currentpdfbookmark` for English bachelor thesis
CreeperLKF May 28, 2024
3d08f6e
doc: add title property in `BITSetup.info` for undergraduate-thesis-en
CreeperLKF May 28, 2024
ba4cf36
fix: toc entry in bookmarks should not point to the tail of toc in Ch…
CreeperLKF May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions bithesis.dtx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@
% \begin{macrocode}
\cs_new:Npn \@@_if_thesis_int_type:nTF #1#2#3 {\int_compare:nNnTF {\g_@@_thesis_type_int} = {#1} {#2} {#3}}
\cs_new:Npn \@@_if_thesis_int_type:nT #1#2 {\@@_if_thesis_int_type:nTF {#1} {#2} {}}
\cs_new:Npn \__bithesis_if_thesis_int_type:nF #1#2 {\__bithesis_if_thesis_int_type:nTF {#1} {} {#2}}
% \end{macrocode}
% \end{macro}

Expand Down Expand Up @@ -2694,13 +2695,16 @@
}

% 添加目录书签
\currentpdfbookmark{\c__bithesis_label_toc_tl}{ch:toc}
\__bithesis_if_thesis_int_type:nF {3} {
\currentpdfbookmark{\c__bithesis_label_toc_tl}{ch:toc}
}

% 制作目录
\tableofcontents

% 在本科生全英文模板中，添加「目录」本身到目录中。
\@@_if_thesis_int_type:nT {3} {
\addcontentsline{toc}{chapter}{\c_@@_label_toc_en_tl}
\__bithesis_if_thesis_int_type:nT {3} {
\addcontentsline{toc}{chapter}{\c__bithesis_label_toc_en_tl}
}

% 单独成页
Expand Down
3 changes: 2 additions & 1 deletion templates/undergraduate-thesis-en/main.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
% 想要删除某项封面信息，直接删除该项即可。
% 想要让某项封面信息留空（但是保留下划线），请传入空白符组成的字符串，如"{~}"。
% 如需要换行，则用 “\\” 符号分割。
title = 你的论文标题（中文）,
titleEn = Your Thesis Title,
school = School of Mechanical Engineering,
major = Bechelor of Science in Mechanical Engineering,
major = Bachelor of Science in Mechanical Engineering,
author = Feng Kaiyu,
studentId = 11xxxxxxxx,
supervisor = Alex Zhang,
Expand Down