-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAGNN random metapath updated #175
base: main
Are you sure you want to change the base?
Conversation
add a metapath_generator in MAGNN model |
------- | ||
Returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsuitable change.
edge_type_list = hg.etypes | ||
metapath_list = [] | ||
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,5,2) | ||
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,3,2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable named "in_feats“ ignored.
edge_type_list = hg.etypes | ||
metapath_list = [] | ||
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,5,2) | ||
metapath_list = metapath_list + metapath_generator(ntypes,edge_type_list,3,2) | ||
metapath_idx_dict = mp_instance_sampler(hg, metapath_list, 'imdb4MAGNN') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change line76 into
"metapath_idx_dict = mp_instance_sampler(hg, metapath_list, agrs.dataset)"
temp = temp + ntypes[random_index] | ||
if temp not in metapath_list: | ||
metapath_list.append(temp) | ||
return metapath_list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAGNN model request all metapath in metapath_list to be symmetric.
This function seems unable to do that...
Description
Checklist
Please feel free to remove inapplicable items for your PR.
Changes