DIG-1833: Query returns all donors to the clinical data table when no donors match a genomic query #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2.0.0: Katsu UUIDs, completeness stats
v2.1.0: Clinical discovery and bugfixes
v2.3.0: Discovery queries
v3.0.0: MoH data model 3, performance improvements
Hotfix: handle 401 unauthorized exceptions
mshadbolt
requested changes
Oct 24, 2024
mshadbolt
approved these changes
Oct 24, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Description
This fixes a bug where Query would return all donors authorized to a user when searching on a gene with no matching donors for the current user, but while there is a matching donor that the user is not authorized to view.
Screenshots
Screencast.from.2024-10-24.10-57-40.webm
To test
make recompose-querywith this branch