-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postprocessing for 4D variables (lat, lon, time, pressure level) #1094
Conversation
4461dfe
to
97ff662
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you Kevin
@@ -48,3 +48,6 @@ must be initialized for each variable of interest. The CliMA model is added with | |||
the `RMSEVariable`. It is assumed that the `RMSEVariable` contains only the columns "DJF", | |||
"MAM", "JJA", "SON", and "ANN" in that order. The file `leaderboard.jl` will load the | |||
appropriate data into the `RMSEVariable`. | |||
|
|||
### Add a new variable to compare against observations in pressure coordinates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to also add a description of the new feature in NEWS.md
function that returns a `OutputVar`. The function must takes in a start date | ||
which is used to align the times in the observational data to match the | ||
simulation data. The short name must be the same as in `sim_var_dict` in the | ||
function `sim_var_dict`. Any preprocessing is done in the function which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function `sim_var_dict`. Any preprocessing is done in the function which | |
function `get_sim_var_dict`. Any preprocessing is done in the function which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which function does the preprocessing + unit conversion + date shifting? It's not totally clear to me here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to rewrite this, but the function that does the post processing is the anonymous function defined in the dictionaries. For example, get_sim_var_dict
returns a dictionary that map short names to functions and those functions are the one that do the preprocessing (unit conversion and data shifting).
4f11200
to
fdc3a5d
Compare
fdc3a5d
to
1cd54c5
Compare
1cd54c5
to
a69d6ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Going to merge this in, but it will be slow. This part of the postprocessing pipeline will be faster once this PR in ClimaAnalysis is merged in. |
The plots added are bias plots at 850 hPa, 500 hPa, and 250 hPa and lat - pressure plots.
a69d6ef
to
6bbd53a
Compare
Purpose
closes #1093 - This PR adds postprocessing for 4D variables (lat, lon, time, pressure level). See plots below.
To-do
Content
Add bias plots after taking time average and slicing at specific pressure levels (850, 500, 250 hPA)
Add bias plots over latitude and pressure level after taking average over time and longitude
I have read and checked the items on the review checklist.