Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS2 support OS app creds #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JS2 support OS app creds #10

wants to merge 2 commits into from

Conversation

almahmoud
Copy link
Collaborator

This was referenced Jun 21, 2022
Merged
Open
Closed
nuwang
nuwang approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think corresponding changes will be needed in the cloudman-ui as well, so the headers are sent?

@nuwang
Copy link
Contributor

nuwang commented Sep 11, 2022

@almahmoud Is this still WIP? Anything more to be done before merging the related PRs?

@almahmoud
Copy link
Collaborator Author

I think everything can be merged. It's missing UI component, but for internal use, that's fine, I just use admin dashboard to populate credentials

@almahmoud almahmoud changed the title [WIP] JS2 support OS app creds JS2 support OS app creds Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuwang nuwang nuwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almahmoud @nuwang