Add application credentials support to OS for JS2 #260
Conversation
django-cloudlaunch/cloudlaunch/backend_plugins/cloudman2/cloudman2_app.py
Outdated
Show resolved
Hide resolved
django-cloudlaunch/cloudlaunch/backend_plugins/cloudman2/cloudman2_app.py
Outdated
Show resolved
Hide resolved
…man2_app.py Co-authored-by: Nuwan Goonasekera <[email protected]>
…man2_app.py Co-authored-by: Nuwan Goonasekera <[email protected]>
django-cloudlaunch/cloudlaunch/backend_plugins/cloudman2_app.py
Outdated
Show resolved
Hide resolved
almahmoud
changed the title
| zone.get('region', {}).get('cloudbridge_settings')) | ||
| if creds.get('os_user_domain_id'): | ||
| domain_entry = f"domain-id={creds.get('os_user_domain_id')}" | ||
| os_user = creds.get('os_username') |
There was a problem hiding this comment.
Will os_username and os_password still work on Jetstream2? In my openrc file they have been replaced with
OS_APPLICATION_CREDENTIAL_ID and OS_APPLICATION_CREDENTIAL_SECRET
There was a problem hiding this comment.
They will not on JS2, the point of this PR is to add support for application credentials. However, given that this is openstack in general, not just for JS2, it's good to leave both options, so other places, eg: Nectar, would still work with user/pass. A few lines below, there is a check for whether both username and password are passed, and otherwise it falls back on application credentials.
There was a problem hiding this comment.
NeCTAR also supports app creds. What if we drop the legacy creds in cloudlaunch, and just stick to app creds only? The UI would certainly become simpler. We can leave things as is in cloudbridge, since we don't want an interface change, but for cloudlaunch, we may as well? Would need to test complete flow through cloudman including adding nodes though. Something we may need to do regardless?
There was a problem hiding this comment.
Ok I don't mind sticking to only app creds then
nuwang
force-pushed
the
master
branch
2 times, most recently
from
39835ff to
78faf84
Compare
Friends with CloudVE/cloudbridge#297 CloudVE/cloudman-boot#56 CloudVE/djcloudbridge#10