Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP8.3 support #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP8.3 support #48

wants to merge 1 commit into from

Conversation

tzi
Copy link
Member

@tzi tzi commented Feb 23, 2024

No description provided.

@achanizbekovidnow
Copy link

Please merge the php8.3 fix to the master

@sc0ttdav3y
Copy link

sc0ttdav3y commented Sep 21, 2024

HI @tzi!

While working on your PHP 8.3 maintenance branch, would you mind also looking at the PHP 8.3 deprecation notices in the current release? I get these notices with 2.3.1 under PHP 8.3.

 [PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadHeader is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:87
 [PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tdSubstitute is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:96
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadBody is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:98

A quick look and it seems ConverterExtra potentially needs three variables declared:

private string $tableLookaheadHeader;
private string $tdSubstitute;
private string $tableLookaheadBody

I see this has been open for a while, so let me know if you need help to conclude it.

Cheers, Scott

@sc0ttdav3y
Copy link

Update: I've created a fresh PR #49 that incorporates this PR and my additional PHP 8.3 deprecation fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants