Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed PHP 8.3 deprecation notices #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sc0ttdav3y
Copy link

@sc0ttdav3y sc0ttdav3y commented Sep 24, 2024

This PR incorporates the work in #48, and adds additional properties to fix the deprecation notices since PHP 8.3:

[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadHeader is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:87
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tdSubstitute is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:96
[PHP Decprecated] Creation of dynamic property Markdownify\ConverterExtra::$tableLookaheadBody is deprecated in /vendor/pixel418/markdownify/src/ConverterExtra.php:98

I have not been able to test via the included tests, as PHPUnit is still at v4 and this is no longer compatible with PHP 8.3 (and I don't have the time to upgrade it in this PR), however this is a minimal change so it should not have any new bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant