Skip to content

Commit

Permalink
workflows: Update workflows for ubuntu 24
Browse files Browse the repository at this point in the history
Remove legacy python3.10 call.
Remove installation of python-tk since it is already included
in the default binares since Python3.7.
Update docs and README.

Signed-off-by: Jonas K. <[email protected]>
  • Loading branch information
EverythingElseWasAlreadyTaken committed Dec 16, 2024
1 parent 6578421 commit 1b6f6bf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/fabric_gen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ jobs:
run: |
python3 -m pip install --upgrade pip
pip3 install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
if [ -f requirements.txt ]; then python3.10 -m pip install -r requirements.txt; fi
sudo apt update
sudo apt install python-tk -y
if [ -f requirements.txt ]; then pip3 install -r requirements.txt; fi
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,17 @@ The following packages need to be installed for generating fabric HDL models and
Install python dependencies

```
sudo apt-get install python3-tk python3-virtualenv
sudo apt-get install python3-virtualenv
```

> [!NOTE]
>
>If you get the warning `ModuleNotFoundError: No module named 'tkinter'` or
>If you get the warning `ModuleNotFoundError: No module named virtualenv` or
>errors when installing the requirements, you have to install the dependencies
>for your specific python version. For Python 3.12 use
>
>```
>sudo apt-get install python3.12-tk python3.12-virtualenv
>sudo apt-get install python3.12-virtualenv
>```
Expand Down
6 changes: 3 additions & 3 deletions docs/source/Usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ Version >= 3.12

.. code-block:: console
$ sudo apt-get install python3-tk python3-virtualenv
$ sudo apt-get install python3-virtualenv
.. note::

If you get the warning ``ModuleNotFoundError: No module named 'tkinter'``
If you get the warning ``ModuleNotFoundError: No module named 'virtualenv'``
or errors when installing the requirements, you have to install the
dependencies for your specific python version. For Python 3.12 use

.. code-block:: console
$ sudo apt-get install python3.12-tk python3.12-virtualenv
$ sudo apt-get install python3.12-virtualenv
:FABulous repository:

Expand Down

0 comments on commit 1b6f6bf

Please sign in to comment.