Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds "loading" and "no data" messages to graphical and tabular displays when relevant #303

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adds "loading" and "no data" messages to graphical and tabular displays when relevant #303

wants to merge 8 commits into from

Conversation

carolinebridge
Copy link
Contributor

@carolinebridge carolinebridge commented Oct 13, 2023 •
edited
Loading

resolves #286

summary of changes

  • adds loading bar to graphical and tabular displays when data is loading and glyphs are being drawn, these messages are dismissed based on when the last loaded element has been drawn in the autorun
  • adds a "no data" message when there is no data to be displayed in the tabular view -- nothing has been loaded or there is nothing to load

loading messages:
image

no data message:
image

@carolinebridge carolinebridge added the enhancement New feature or request label Oct 13, 2023
@carolinebridge carolinebridge self-assigned this Oct 13, 2023
carolinebridge
carolinebridge commented Oct 13, 2023
View reviewed changes
Copy link
Contributor Author

@carolinebridge carolinebridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrettjstevens

Let me know if the UI aligns with the styling you had in mind. Currently both messages are zIndex: 10 hovering in the top right corner of the graphical and tabular views.

packages/jbrowse-plugin-apollo/src/TabularEditor/HybridGrid/HybridGrid.tsx Outdated
const visibleFeatures = [...seenFeatures.entries()].filter((entry) => {
const [, feature] = entry
return (
feature.start > visibleRegion.start && feature.end < visibleRegion.end

This comment was marked as outdated.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: styling, for the table it might be better to have it centred in the table like a data grid MUI component, subjective though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjstevens garrettjstevens Awaiting requested review from garrettjstevens

Assignees

@carolinebridge carolinebridge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Loading" and "No data" messages
1 participant
@carolinebridge