Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move capture page to /captures #1804

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

yunchipang
Copy link
Collaborator

@yunchipang yunchipang commented Oct 30, 2024

Description

Fixes #1768

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Screenshot 2024-11-04 at 6 58 02 PM

How Has This Been Tested?

  • Cypress integration
  • Cypress component tests
  • Jest unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -80,7 +80,7 @@ function FeaturedTreesSlider({ trees, size = null, isMobile, link }) {
>
{trees.map((tree) => (
<Link
href={link ? link(tree) : `/v2/captures/${tree.id}`}
href={link ? link(tree) : `/captures/${tree.id}`}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen this is what you're looking for?
cypress integration test is not added yet. just checking if i'm on the right path.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunchipang yes, and to finish this, we also need a integration test for this: /capture page

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it?

Copy link
Collaborator

@dadiorchen dadiorchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunchipang this is the right way to go, I guess you passed it on your local env, but on the ci it's broken:
image
https://github.com/Greenstand/treetracker-web-map-client/actions/runs/11695766183/job/32571757532?pr=1804#step:3:147

can you take a look

@yunchipang yunchipang requested a review from dadiorchen November 8, 2024 19:07
clearNocks();
});

describe('Capture page', () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen cypress integration test for the capture page has been added and passed. could you kindly take a look? i have requested another review from you. thanks!

@dadiorchen dadiorchen merged commit 5513d9f into Greenstand:v2 Nov 11, 2024
3 checks passed
@yunchipang yunchipang deleted the refactor/move-capture-page branch November 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants