-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: move capture page to /captures #1804
Refactor: move capture page to /captures #1804
Conversation
@@ -80,7 +80,7 @@ function FeaturedTreesSlider({ trees, size = null, isMobile, link }) { | |||
> | |||
{trees.map((tree) => ( | |||
<Link | |||
href={link ? link(tree) : `/v2/captures/${tree.id}`} | |||
href={link ? link(tree) : `/captures/${tree.id}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dadiorchen this is what you're looking for?
cypress integration test is not added yet. just checking if i'm on the right path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunchipang yes, and to finish this, we also need a integration test for this: /capture page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunchipang this is the right way to go, I guess you passed it on your local env, but on the ci it's broken:
https://github.com/Greenstand/treetracker-web-map-client/actions/runs/11695766183/job/32571757532?pr=1804#step:3:147
can you take a look
clearNocks(); | ||
}); | ||
|
||
describe('Capture page', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dadiorchen cypress integration test for the capture page has been added and passed. could you kindly take a look? i have requested another review from you. thanks!
Description
Fixes #1768
Type of change
Screenshots
How Has This Been Tested?
Checklist: