Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move capture page to /captures #1804

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Refactor: move capture page to /captures #1804

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
abec9b6
refactor: move capture page from /v2/captures to /captures
yunchipang Oct 30, 2024
2d717da
feat: capture page works
yunchipang Nov 5, 2024
60a7083
chore: undo api endpoints change
yunchipang Nov 6, 2024
a2517df
chore: remove unused code
yunchipang Nov 6, 2024
2347161
fix: fix Warning: Each child in a list should have a unique 'key' prop
yunchipang Nov 8, 2024
cde9af8
test: cypress integration test for capture passed
yunchipang Nov 8, 2024
e82fa3a
test: improve test description
yunchipang Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FeaturedTreesSlider/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function FeaturedTreesSlider({ trees, size = null, isMobile, link }) {
>
{trees.map((tree) => (
<Link
href={link ? link(tree) : `/v2/captures/${tree.id}`}
href={link ? link(tree) : `/captures/${tree.id}`}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadiorchen this is what you're looking for?
cypress integration test is not added yet. just checking if i'm on the right path.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunchipang yes, and to finish this, we also need a integration test for this: /capture page

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it?

key={`featured-tree-${tree.id}`}
>
<Card
Expand Down
Loading