SNS - Changes for IMUs to work #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 38.20% 38.16% -0.04%
==========================================
Files 69 69
Lines 3942 3946 +4
==========================================
Hits 1506 1506
- Misses 2436 2440 +4
Continue to review full report at Codecov.
|
kshxtij
requested changes
Jun 10, 2022
mifrandir
requested changes
Jun 23, 2022
| @@ -105,7 +105,7 @@ Spi::Spi(Logger &log) : spi_fd_(-1), hw_(0), ch_(0), log_(log) | |||
| } | |||
|
|
|||
| // set clock frequency | |||
| setClock(Clock::k1MHz); | |||
| setClock(Clock::k500KHz); | |||
There was a problem hiding this comment.
Is this required? Did we test it? Has it to do with the new IMUs?
There was a problem hiding this comment.
Yes, yes and yes. Although this just needs to be tested with the sensors PCB but with an individual IMU, this worked.
mifrandir
requested changes
Jul 15, 2022
| @@ -133,7 +133,7 @@ void Gpio::exportGPIO() | |||
| // let the kernel know we are using this pin | |||
| int fd; | |||
| uint32_t len; | |||
| fd = open("/sys/class/gpio/export", O_WRONLY); | |||
| fd = open("/sys/class/gpio/export", O_RDWR); | |||
There was a problem hiding this comment.
You've touched this line now so we need to do this properly.
const auto fd = open(/* ... */);Similar for len.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight modifications which gets the IMU-20948 to work with our code on the beagleboneblack.
Giving read and write permissions when opening gpio export file to prevent consistent export errors.