Update to the UserListensResponse models to add MBID mapping (No Doc) #24
Conversation
|
Also, CI has failed. This needs to be resolved before merge. |
|
Finally, commits need to be documented a bit more. Currently, they're just one-liners with no justification or detail. The PR desc could be improved too. Maybe might be worth squashing into one commit too, if it's just for one change. |
|
Sorry I didn't get to squash those commits while pushing the .gitignore fix. But since it's already approved by one, should it just be done while merging? |
|
I would rather the last three commits are squashed into one, rebased against main, and then reworded to describe the changes. Currently, it'll lead to a somewhat confusing commit history if we merge as-is. Sorry, I'm not trying to hold up the PR - just trying to keep a easy to understand commit history. |
RustyNova016
force-pushed
the
updates/UserListens-nodocs
branch
from
f2f01d3 to
6b35a7c
Compare
RustyNova016
force-pushed
the
updates/UserListens-nodocs
branch
from
6b35a7c to
1bb9d32
Compare
|
Sorry, I was busy all week. Should be good! |
InputUsername
force-pushed
the
updates/UserListens-nodocs
branch
from
1bb9d32 to
bcb8469
Compare
|
Neat! Only waiting for the release now. I'll first work on #25 now that those are merged and I'll go back to adding random stuff that I need |
Here is the version without documentation for the MBID Mapping from #22.
It also removes the timerange parameter as it isn't used in the API anymore.