Module splitting #31
Open
Module splitting #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @RustyNova016, for the next release (0.8.1) I'd like to merge this PR first, but there are merge conflicts now. Would you be able to solve those? If not, feel free to close this PR and create a new one. I really like these changes though, great job 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started splitting the modules into multiples ones according to #25. For now only Core is made, but I am creating this pull request for tracking and initial review
Here's some details:
response_typemacro to have absolute paths and thus being able to be used in children modules.{request type} {apipath}, like shown in the official documentation. While the original ones are closer to string formatting, the new ones are easier to find with a ctrl-f from the official documentation.