Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Global Report V2 #634

Conversation

mohamedawnallah
Copy link
Member

@mohamedawnallah mohamedawnallah commented Nov 3, 2023

Description

This pull request addresses the following:

  1. Empowered users to filter the bottom table with precision by selecting criteria such as country, ASN, time, severity, and IP address family.
  2. Identified and extracted hegemony alarms exhibiting a substantial deviation of less than -20, ensuring a focus on the most critical anomalies.
  3. Revamped the interface by renaming 'reset granularity' to 'show all countries’ and moving the buttons next to the data vizs for greater clarity and convenience.
  4. Introduced versatile options for switching between originasn and asn for AS hegemony alarms, start and endpoint for network delay alarms, and attacker and victim for GRIP Alarms.
  5. Enhanced control by enabling the filtering of alarms by IP address families 4 and 6.
  6. Expanded our system by adding disco alarms to the list of IHR alarms.
  7. Tailored the dashboard to offer the ability to select a default alarm type(s), with hegemony as the new default.
  8. Fostered a seamless and engaging experience by integrating full interactivity among data visualizations, including the WorldMap, TreeMap, TimeSeries, and Table Data Visualizations.
  9. Enhanced performance by accelerating the loading of the dashboard, bypassing network requests to retrieve AS names and country information from IHR networks and instead utilizing RIPE's asnames.txt file.
  10. Introduced comprehensive overviews for Neighbor Dependency in Hegemony, Round-Trip Time in Network Delay, Latency Overview in Network Delay, and AS and Country Internet in IODA, along with a reusable aggregated overview spanning IHR, GRIP, and IODA data sources.
  11. Identified and logged dynamically missing autonomous systems not found in the asnames.txt file, making it a potentially valuable "good first issue" for contributors.
  12. Addressed critical bugs related to the ASInterdependenciesChart.vue component, ensuring seamless data handling. Bug/ASInterdependenciesChart.vue component Doesn't Handle All Data Points #632 Bug/ASInterdependenciesChart.vue component gives null pointer exception on getTime() #633
  13. Welcomed Merit Network Telescope as a new IODA Alarm Type and integrated Google Transparency Report [Google Search] into AS and Country Internet IODA Overview.
  14. Enhanced the user experience with custom dynamic metrics in data visualization titles, adapting dynamically to the user's journey through the dashboard.
  15. Updated documentation for streamlined processes and enhanced user experience, including alarm type and data source addition, default alarm type selection, group by key customization, and text content modification in filters and data visualizations, facilitating efficient system configuration and text personalization.

How Has This Been Tested?

Rigorously validated with an extensive suite of 133 comprehensive test cases.

Recordings

global-report-v2.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mohamedawnallah mohamedawnallah added the enhancement New feature or request label Nov 3, 2023
@mohamedawnallah mohamedawnallah self-assigned this Nov 3, 2023
@romain-fontugne
Copy link
Member

romain-fontugne commented Nov 16, 2023

🤩
This is great, I think we can cleanup a bit the page now, for example the date/calendar a the top is not needed anymore. Also maybe to make the page faster we could show only one day of data?
And we can also remove the two bottom tabs (link delay and net. disconnection)

@mohamedawnallah
Copy link
Member Author

mohamedawnallah commented Nov 16, 2023

Thanks for the feedback! I think so regards showing only one day of data that would be a lot faster especially incase of Hegemony Alarms where we get >20 and <-20 alarms.

I have implemented the suggested changes. Please check them out and let me know!

global-report-v2-updated

@romain-fontugne
Copy link
Member

So now I'm not sure I use that correctly. Let's say I want to look at results a few days ago. I try to set the dates in the time filter fields and click on apply but it doesn't work?

These fields are only for filtering results? If so then we might want to put back the date at the top of the page

@mohamedawnallah
Copy link
Member Author

mohamedawnallah commented Nov 24, 2023

@romain-fontugne Yes those time filters for filtering the results only. In the new commits I’ve done the following:

  • Returned the date time picker and make interactive with other data visualizations.
  • Solved the Redundant Navigation error in the global report page.
  • Made the IHR Network Requests Asynchronous. In the previous case where we got 3 day report I made it Synchronous so not to put the IHR server down. Now In our one day report making it Asynchronous would be fine .

PS:
I will open good first issue after this PR for other pages where Redundant Navigation Error happens and how to solve it.

@romain-fontugne
Copy link
Member

Looks great, thanks!

@romain-fontugne romain-fontugne merged commit f694d4b into InternetHealthReport:master Nov 29, 2023
2 checks passed
@romain-fontugne
Copy link
Member

romain-fontugne commented Nov 29, 2023

ah wait, it looks like the AS hegemony graphs now throw an error when we click on it?

 Error in v-on handler: "TypeError: clickData.points is undefined"

@mohamedawnallah
Copy link
Member Author

Thanks for the catch! Addressed in this PR #642

@mohamedawnallah
Copy link
Member Author

@romain-fontugne we may also need to change the ? icon info for Network Disconnection Alarms in the filters table. I made placeholder text “Network Disconnection Alarms"
2023-11-30_08-20

@romain-fontugne
Copy link
Member

Ok, thanks! I'll take care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants