-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Global Report V2 #634
Feature/Global Report V2 #634
Conversation
…r, and vue/no-mutating-props in linting process
🤩 |
So now I'm not sure I use that correctly. Let's say I want to look at results a few days ago. I try to set the dates in the time filter fields and click on apply but it doesn't work? These fields are only for filtering results? If so then we might want to put back the date at the top of the page |
@romain-fontugne Yes those time filters for filtering the results only. In the new commits I’ve done the following:
PS: |
Looks great, thanks! |
ah wait, it looks like the AS hegemony graphs now throw an error when we click on it?
|
Thanks for the catch! Addressed in this PR #642 |
@romain-fontugne we may also need to change the ? icon info for Network Disconnection Alarms in the filters table. I made placeholder text “Network Disconnection Alarms" |
Ok, thanks! I'll take care of this |
Description
This pull request addresses the following:
How Has This Been Tested?
Rigorously validated with an extensive suite of 133 comprehensive test cases.
Recordings
global-report-v2.mov
Types of changes
Checklist: