Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix/Handle null pointer when the as hegemony graph clicked in the network report #642

Conversation

mohamedawnallah
Copy link
Member

Description

Fixes: Error in v-on handler: "TypeError: clickData.points is undefined"

Motivation and Context

#634 (comment)

Recordings

network_report_as_hegemony_nullptr_click.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…ata.points is undefined in as hegemony graph
@mohamedawnallah mohamedawnallah added the bug Something isn't working label Nov 30, 2023
@mohamedawnallah mohamedawnallah mentioned this pull request Nov 30, 2023
6 tasks
@romain-fontugne
Copy link
Member

hmmm, I see a lot more breaking things now:

  1. Why is the graph now reloading everytime we click on it?
  2. It seems that the 'Direct Neighbor' column in the table is not updated

@mohamedawnallah
Copy link
Member Author

mohamedawnallah commented Nov 30, 2023

Okay the main issue is that I used the interval computed property in the ReportMixin.vue which under the hood listens for the changes of query date field. This works well for getting alarms from X time to Y time but this cause re-rendering of the data vizs when clicked because the dates is updated in the query address.

I handled the case of reloading the graph everytime as shown in the following video

re-rendering-as-hegemony-network-report.mov

@mohamedawnallah
Copy link
Member Author

@romain-fontugne Could you please elaborate more on this:
"It seems that the 'Direct Neighbor' column in the table is not updated"

@romain-fontugne
Copy link
Member

@romain-fontugne Could you please elaborate more on this: "It seems that the 'Direct Neighbor' column in the table is not updated"

From your last screenshot it seems to work as expected. Thanks!

@romain-fontugne romain-fontugne merged commit ba63337 into InternetHealthReport:master Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants