Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to extract anchor data from certificate #664

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 25, 2024

Changelog

- description: |
    - Add function to extract anchor data from a certificate
  type:
  - feature

Context

This PR is part of addressing this review comment. It moves the extracting of anchor data into cardano-api together with the rest of code that inspects certificates for easier maintenance.

Related PRs

How to trust this PR

It is quite analogous to filterUnRegDRepCreds, except it does some conversion from PoolMetadata to AnchorData which are analogous types.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Oct 25, 2024
@palas palas self-assigned this Oct 25, 2024
@palas palas force-pushed the add-anchor-data-extraction branch 3 times, most recently from d5a471e to b00053d Compare October 25, 2024 15:09
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick with Either please. I don't want a mixture of MonadError and Either.

@palas palas force-pushed the add-anchor-data-extraction branch from acd50a4 to 10f3b42 Compare October 31, 2024 11:17
@palas palas requested review from Jimbo4350 and carbolymer October 31, 2024 11:20
@palas palas force-pushed the add-anchor-data-extraction branch 3 times, most recently from 694008a to d5e0a29 Compare October 31, 2024 13:29
@palas palas force-pushed the add-anchor-data-extraction branch from d5e0a29 to 62a42f4 Compare November 4, 2024 13:20
@palas palas enabled auto-merge November 4, 2024 13:23
@palas palas added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit 5c67a60 Nov 4, 2024
25 checks passed
@palas palas deleted the add-anchor-data-extraction branch November 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants