-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to extract anchor data from certificate #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
carbolymer,
smelc,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
October 25, 2024 14:02
palas
force-pushed
the
add-anchor-data-extraction
branch
3 times, most recently
from
October 25, 2024 15:09
d5a471e
to
b00053d
Compare
3 tasks
Jimbo4350
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's stick with Either
please. I don't want a mixture of MonadError
and Either
.
carbolymer
reviewed
Oct 28, 2024
carbolymer
reviewed
Oct 28, 2024
9 tasks
Jimbo4350
reviewed
Oct 30, 2024
carbolymer
reviewed
Oct 31, 2024
palas
force-pushed
the
add-anchor-data-extraction
branch
from
October 31, 2024 11:17
acd50a4
to
10f3b42
Compare
palas
force-pushed
the
add-anchor-data-extraction
branch
3 times, most recently
from
October 31, 2024 13:29
694008a
to
d5e0a29
Compare
Jimbo4350
approved these changes
Nov 4, 2024
palas
force-pushed
the
add-anchor-data-extraction
branch
from
November 4, 2024 13:20
d5e0a29
to
62a42f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR is part of addressing this review comment. It moves the extracting of
anchor data
intocardano-api
together with the rest of code that inspects certificates for easier maintenance.Related PRs
transaction build
cardano-cli#951How to trust this PR
It is quite analogous to
filterUnRegDRepCreds
, except it does some conversion fromPoolMetadata
toAnchorData
which are analogous types.Checklist