Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash check in transaction build tests #6023

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Hash check in transaction build tests #6023

wants to merge 13 commits into from
+502 −146

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 24, 2024 •
edited
Loading

DO NOT MERGE: Need to remove the SRP stanza

Description

This PR updates tests in cardano-testnet to work with the new check of anchor hashes added to transaction build (see IntersectMBO/cardano-cli#951).

Related PRs

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@palas palas self-assigned this Oct 24, 2024
@palas palas requested a review from a team as a code owner October 24, 2024 14:28
@palas palas linked an issue Oct 24, 2024 that may be closed by this pull request
[FR] - Add File Hash Validation when Building Transaction IntersectMBO/cardano-cli#882
Closed
@palas palas mentioned this pull request Oct 25, 2024
Merged
3 tasks
Jimbo4350
Jimbo4350 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few suggestions.

cardano-testnet/src/Testnet/Process/Run.hs Show resolved Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/ProposeNewConstitution.hs Show resolved Hide resolved
cardano-testnet/test/cardano-testnet-test/files/sample-constitution-anchor
@@ -0,0 +1,50 @@
Preamble

We, the zaniest inhabitants of the peculiar and bewildering land of Barataria, in honor of our illustrious Governor, Sancho Panza, renowned for his comically charming ordinances, do hereby present this Constitution to tickle your fancy and uphold the values of laughter, merriment, and the pursuit of hilarity for all our citizens.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chat GPT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I downloaded it from the shortened link that was there before: https://tinyurl.com/2pahcy6z. It seems an old gist by @carloslodelar. @CarlosLopezDeLara, was that you? do you know the origin of it?

cardano-testnet/cardano-testnet.cabal Outdated Show resolved Hide resolved
@palas palas force-pushed the hash-check-in-transaction-build-tests branch 2 times, most recently from 25cd53a to 7e14eb8 Compare October 28, 2024 22:07
@palas palas mentioned this pull request Oct 29, 2024
Merged
3 tasks
@palas palas requested review from a team as code owners October 29, 2024 11:05
@palas palas force-pushed the hash-check-in-transaction-build-tests branch 7 times, most recently from d641b5f to e3fb8f9 Compare October 29, 2024 17:22
@palas palas force-pushed the hash-check-in-transaction-build-tests branch from e3fb8f9 to 6aea891 Compare October 31, 2024 14:19
@smelc smelc added next-update Needs a dependency to be updated to be merged and removed next-update labels Nov 14, 2024
@palas palas requested a review from carbolymer November 15, 2024 12:29
@palas palas force-pushed the hash-check-in-transaction-build-tests branch from 3b8f839 to 49efdb9 Compare November 15, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer Awaiting requested review from carbolymer

Assignees

@palas palas

Labels
cardano-testnet DO NOT MERGE next-update Needs a dependency to be updated to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Add File Hash Validation when Building Transaction
4 participants
@palas @carbolymer @Jimbo4350 @smelc