Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyarrow #1317

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Upgrade pyarrow #1317

merged 4 commits into from
Nov 10, 2023

Conversation

djherbis
Copy link
Contributor

http://b/310037300
Dockerfile.tmpl Outdated Show resolved Hide resolved
@djherbis
Copy link
Contributor Author

This could be a problem:

cudf 23.8.0 requires pyarrow==11.*, but you have pyarrow 14.0.1 which is incompatible.

@SohierDane
Copy link
Contributor

This could be a problem:

cudf 23.8.0 requires pyarrow==11.*, but you have pyarrow 14.0.1 which is incompatible.

Honestly, I think we can live with that. Very few metrics use GPUs and most of those are processing model files and so won't be affected by PyArrow versions one way or the other. There should be so few remaining GPU metrics that we can reasonably just plan on not enabling parquet support for them.

Dockerfile.tmpl Outdated
@@ -114,7 +114,7 @@ RUN pip install spacy && \

# b/232247930: uninstall pyarrow to avoid double installation with the GPU specific version.
RUN pip uninstall -y pyarrow && \
mamba install -y cudf cuml && \
mamba install -y "pyarrow>=14.0.1" cudf cuml && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this passes, if it does we'll upgrade both, if not, then we'll switch to only upgrading the CPU-image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that without this change, it does look like tests pass:
https://ci.kaggle.net/blue/organizations/jenkins/kernels%2Fdocker-python/detail/upgrade-pyarrow/1/pipeline/58/

So cudf is complaining, but it might work anyway...? Though we might not want to risk that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to risk it.

@djherbis djherbis merged commit 395d333 into main Nov 10, 2023
3 checks passed
@djherbis djherbis deleted the upgrade-pyarrow branch November 10, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants