Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyarrow #1317

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Upgrade pyarrow #1317

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb3a31c
upgrade pyarrow
djherbis Nov 10, 2023
60c13b4
pyarrow>=14.0.1
djherbis Nov 10, 2023
496c394
Require cudf and pyarrow to be consistent
djherbis Nov 10, 2023
492257c
Only upgrade pyarrow on CPU image
djherbis Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ RUN pip install spacy && \

# b/232247930: uninstall pyarrow to avoid double installation with the GPU specific version.
RUN pip uninstall -y pyarrow && \
mamba install -y cudf cuml && \
mamba install -y "pyarrow>=14.0.1" cudf cuml && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this passes, if it does we'll upgrade both, if not, then we'll switch to only upgrading the CPU-image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that without this change, it does look like tests pass:
https://ci.kaggle.net/blue/organizations/jenkins/kernels%2Fdocker-python/detail/upgrade-pyarrow/1/pipeline/58/

So cudf is complaining, but it might work anyway...? Though we might not want to risk that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to risk it.

/tmp/clean-layer.sh

# TODO: b/296444923 - Resolve pandas dependency another way
Expand Down Expand Up @@ -240,8 +240,7 @@ RUN apt-get install -y libfreetype6-dev && \
scikit-image && \
/tmp/clean-layer.sh

RUN pip install ibis-framework && \
pip install opencv-contrib-python opencv-python && \
RUN pip install opencv-contrib-python opencv-python && \
/tmp/clean-layer.sh

RUN pip install scipy \
Expand Down Expand Up @@ -481,7 +480,8 @@ RUN pip install bleach \
wcwidth \
webencodings \
widgetsnbextension \
pyarrow \
# Require pyarrow newer than https://github.com/advisories/GHSA-5wvp-7f3h-6wmm
"pyarrow>=14.0.1" \
feather-format \
fastai

Expand Down