Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormalBumpBakingMethods #88

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

echadwick-artist
Copy link
Contributor

@echadwick-artist echadwick-artist commented Dec 22, 2023

To stress-test baked tangent-space normal bump maps.

screenshot_Large

echadwick-artist and others added 2 commits December 22, 2023 17:44
To stress-test baked tangent-space normal bump maps.
Corrected spelling errors, and added a section on Source Textures.
* Blender examples added.
* Binary files renamed for clarity.
* Screenshot switched from glTF Sample Viewer to Babylon.js Sandbox, to demonstrate a successful rendering rather than a failed one.
* Readme improvements.
Additional info added to the readme about tangents, and fixed a malformed link for MikkTSpace.
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This group of models looks really cool! It reminds me of the game "Portal."


## Tangent Space

Tangent space normal bump maps are often used in two ways:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the word "bump" here and throughout? I believe the proper name is "Tangent space normal map".

The terms "bump" and "bump map" are older and less well defined, often referring to height maps, displacement maps, and the like. Let's avoid saying "bump" here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants